From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D424C282CB for ; Tue, 5 Feb 2019 18:41:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8B402175B for ; Tue, 5 Feb 2019 18:41:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730386AbfBESlH (ORCPT ); Tue, 5 Feb 2019 13:41:07 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46482 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfBESlH (ORCPT ); Tue, 5 Feb 2019 13:41:07 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 246B9133FABCD; Tue, 5 Feb 2019 10:41:07 -0800 (PST) Date: Tue, 05 Feb 2019 10:41:06 -0800 (PST) Message-Id: <20190205.104106.1863991682465983305.davem@davemloft.net> To: rmk+kernel@armlinux.org.uk Cc: antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com, baruch@tkos.co.il, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: marvell: mvpp2: fix lack of link interrupts From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Feb 2019 10:41:07 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Russell King Date: Mon, 04 Feb 2019 23:35:59 +0000 > Sven Auhagen reports that if he changes a SFP+ module for a SFP module > on the Macchiatobin Single Shot, the link does not come back up. For > Sven, it is as easy as: > > - Insert a SFP+ module connected, and use ping6 to verify link is up. > - Remove SFP+ module > - Insert SFP 1000base-X module use ping6 to verify link is up: Link > up event did not trigger and the link is down > > but that doesn't show the problem for me. Locally, this has been > reproduced by: > > - Boot with no modules. > - Insert SFP+ module, confirm link is up. > - Replace module with 25000base-X module. Confirm link is up. > - Set remote end down, link is reported as dropped at both ends. > - Set remote end up, link is reported up at remote end, but not local > end due to lack of link interrupt. > > Fix this by setting up both GMAC and XLG interrupts for port 0, but > only unmasking the appropriate interrupt according to the current mode > set in the mac_config() method. However, only do the mask/unmask > dance when we are really changing the link mode to avoid missing any > link interrupts. > > Tested-by: Sven Auhagen > Signed-off-by: Russell King Applied.