From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA113C282CB for ; Wed, 6 Feb 2019 00:36:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D9BF2183E for ; Wed, 6 Feb 2019 00:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727543AbfBFAgo (ORCPT ); Tue, 5 Feb 2019 19:36:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:51724 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727165AbfBFAgn (ORCPT ); Tue, 5 Feb 2019 19:36:43 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 58D6D133FABCB; Tue, 5 Feb 2019 16:36:43 -0800 (PST) Date: Tue, 05 Feb 2019 16:36:40 -0800 (PST) Message-Id: <20190205.163640.175589510190486514.davem@davemloft.net> To: tuba@ece.ufl.edu Cc: netdev@vger.kernel.org Subject: Re: [PATCH]: net: hso: do not call unregister if not registered From: David Miller In-Reply-To: <1549407687058.71019@ece.ufl.edu> References: <1549407687058.71019@ece.ufl.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Feb 2019 16:36:43 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Yavuz, Tuba" Date: Tue, 5 Feb 2019 23:01:25 +0000 > > > On an error path inside the hso_create_net_device function of the hso > driver, hso_free_net_device gets called. This causes potentially a > negative reference count in the net device if register_netdev has not > been called yet as hso_free_net_device calls unregister_netdev > regardless. I think the driver should distinguish these cases and call > unregister_netdev only if register_netdev has been called. > > Signed-off-by: Tuba Yavuz > --- > > --- linux-stable/drivers/net/usb/hso.c.orig 2019-01-27 14:45:58.232683119 -0500 > +++ linux-stable/drivers/net/usb/hso.c 2019-02-05 17:54:17.056496019 -0500 > @@ -2377,7 +2377,9 @@ static void hso_free_net_device(struct h > > remove_net_device(hso_net->parent); > > - if (hso_net->net) > + if (hso_net->net && > + hso_net->net->reg_state == NETREG_REGISTERED > + ) This is not formatted correctly, the final closing ')' should end the previous line, like this: if (hso_net->net && hso_net->net->reg_state == NETREG_REGISTERED)