From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 936E7C282CB for ; Tue, 5 Feb 2019 11:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 608AB20821 for ; Tue, 5 Feb 2019 11:31:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="MjPA3vnB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728124AbfBELbq (ORCPT ); Tue, 5 Feb 2019 06:31:46 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:34185 "EHLO mail-wm1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727884AbfBELbp (ORCPT ); Tue, 5 Feb 2019 06:31:45 -0500 Received: by mail-wm1-f47.google.com with SMTP id y185so12305316wmd.1 for ; Tue, 05 Feb 2019 03:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KLzssv9X1PcP69EYU/KU6x9XIA44zt83kZOuz8prea8=; b=MjPA3vnBIzcqZsMk+MDSflhk3PFhOejG5SHFoaAwweVnsAsoyk1iCZhyKjs+JuLsC8 0tZzkGntSVkjlan0d9RXwIbFgiVbEL57bK85egpinKnid+bb/NVImkWNJlzMD7dFvrWm qkKYnKVCg+OZ2DO6XXqHUQHPYXVd3A3aYSABztaNdCFITNn27UvuwFaEFBAAvgqSVFn0 7mHdiUOedX1DE8mp22182v83qzGbDpmiypfIrhNGm9Vp+BORqBGDWyonmu9XdrT0Yssw l5eSSevCmlqDJo/yyuzYbcl+PcuJ6Bg0K5GMGTIGTEFeiLzuDSVJ8xXg1B0UNJKQbQ6O MN1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KLzssv9X1PcP69EYU/KU6x9XIA44zt83kZOuz8prea8=; b=cziHXoEs2q+zU800iLgNlb8ZsNlTZ11T7ErHkxYgtI0U5irVdOZM+G/ELVvMYED011 +5Yqhghzk4SAaYwcTvSh9w5lpoaI7mryWRK2L6ajCgov0W0DBg8ZnNCRK2N1WUrbPOfo iSfUJPE3xwEJ3C1xds5QUqNrF7meSmMT8S2mQ49MYh1VJW7MBkJopY/2ZnIMilqzahLP qrRzcNUBOTsGWzy9quxZfyqEHbo32oyNG2NpGcmJ3OFwYmRmrL7bgSELV4fq8GiLqxsk 79uecbWbKoDEJ5/kR+7bbdvIzWtiJvTJ7rHcUd40neJL1IMn2BCtGp24F6TiMDYcKEYF iEXg== X-Gm-Message-State: AHQUAuYDQ4GHgMSfoSaTAbPrL95BSZD+tQzsNcIH/JnpZvH/l04QGcad V8tZehCnTn0L34544QXFaKOAAQ== X-Google-Smtp-Source: AHgI3IbnxGBV05y/0sNCtB2T0WXZwFS86grS8Erw6qeIs/0jG22WMcnL6vugN75eEhJvAZDL2hZx3Q== X-Received: by 2002:a1c:7f0c:: with SMTP id a12mr3200106wmd.89.1549366303965; Tue, 05 Feb 2019 03:31:43 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id p4sm15546839wrs.74.2019.02.05.03.31.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 03:31:43 -0800 (PST) Date: Tue, 5 Feb 2019 12:22:33 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net Subject: Re: [PATCH net-next v3 07/16] net: sched: introduce reference counting for tcf_proto Message-ID: <20190205112233.GD2133@nanopsycho> References: <20190204123301.4223-1-vladbu@mellanox.com> <20190204123301.4223-8-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204123301.4223-8-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 01:32:52PM CET, vladbu@mellanox.com wrote: >In order to remove dependency on rtnl lock and allow concurrent tcf_proto >modification, extend tcf_proto with reference counter. Implement helper >get/put functions for tcf proto and use them to modify cls API to always >take reference to tcf_proto while using it. Only release reference to >parent chain after releasing last reference to tp. > >Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko