From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BADD2C282CB for ; Tue, 5 Feb 2019 13:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DF78206DD for ; Tue, 5 Feb 2019 13:17:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="lAhpDzJp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729324AbfBENRw (ORCPT ); Tue, 5 Feb 2019 08:17:52 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38137 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbfBENRw (ORCPT ); Tue, 5 Feb 2019 08:17:52 -0500 Received: by mail-wm1-f66.google.com with SMTP id m22so3635848wml.3 for ; Tue, 05 Feb 2019 05:17:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5j7nZxGbwCtpR5npGERuM9cSi1r2VqZU6/VcmqZIn0k=; b=lAhpDzJplPcHsoSUm8dthR6sVJLSbvthzl2hR3yTbJMULFFuJsxFH/7zTYctKUaoRO rTgsK2XUGAuHk9WsZxqrTbYKt2GAZJGR6F8XYj2Ob1cBtm7x4rU5AD/P2AXralzVC4vI FNx94i3GNnxk6qLFZBgdDe851AQ3c45zQIEFsLde0dsSPSw+Jp0NKKhU+Nhms+4V6N61 KGPOl5t06ITsxto0T/xosGb98eEBCAUSXXmyj2h+8PXVx48gTLu3JUUJVgNzC22+3Haj XOx+fv86GrnnhKPpUoINWxmM6jSG6mX0ZrjxigT22x0bwGdtgpLdIaiGLxn61xdteN2/ /P2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5j7nZxGbwCtpR5npGERuM9cSi1r2VqZU6/VcmqZIn0k=; b=ZSFEeLNJ4N5JbeuZTSA3L/g+JwA//1KurybbVBjneeUccZcw9dUBbdPCjT3zZiOkC/ Yx5QeqRoGsyvL0hUNbn9uLOcRvXwAdC5W/1+v+sBeK3Dc2UiaKSD8kHjCWBEj3tl6iQh 3g1IQxWTctsgbGxo2D+rg20waxYnb1iUGdIJ5lqqaHoC62DUkuvrxMQ0A96z3WrBmtAB ce9jd96qmcBOvDft1CKxkeOVTKYoJVUoGLPMINSDhF/FaHRyL63YEJQr4RR1SOS7f4jj HjIIr6yHTpg4aJUrE8XlmmX4gxrere4QR7MttGKBHVPs2B4Zu2rSkjnYjBI1yIxXywNx 6aaw== X-Gm-Message-State: AHQUAuY1Zub2jUZpXgPqM6s1E9oHp9zMxnrTd3R50G7OQeQdr6A3gUiQ qxfBFoqGMOuZL/Ct0u0fv/ohyQ== X-Google-Smtp-Source: AHgI3IYjMfpBb4DgW70W9Tjg/a8XJCPTO8ocyKFkxufASqTfQ7qeJJ94zffO3AtMMDlvzBHekp/uUQ== X-Received: by 2002:a1c:448a:: with SMTP id r132mr3573472wma.47.1549372670540; Tue, 05 Feb 2019 05:17:50 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id g25sm983367wmh.25.2019.02.05.05.17.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 05:17:47 -0800 (PST) Date: Tue, 5 Feb 2019 14:08:38 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net Subject: Re: [PATCH net-next v3 10/16] net: sched: prevent insertion of new classifiers during chain flush Message-ID: <20190205130838.GG2133@nanopsycho> References: <20190204123301.4223-1-vladbu@mellanox.com> <20190204123301.4223-11-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204123301.4223-11-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 01:32:55PM CET, vladbu@mellanox.com wrote: >Extend tcf_chain with 'flushing' flag. Use the flag to prevent insertion of >new classifier instances when chain flushing is in progress in order to >prevent resource leak when tcf_proto is created by unlocked users >concurrently. > >Return EAGAIN error from tcf_chain_tp_insert_unique() to restart >tc_new_tfilter() and lookup the chain/proto again. > >Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko