From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD71C282CB for ; Tue, 5 Feb 2019 13:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D30F206DD for ; Tue, 5 Feb 2019 13:18:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="y0CDmgX+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729415AbfBENSQ (ORCPT ); Tue, 5 Feb 2019 08:18:16 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:36874 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726456AbfBENSP (ORCPT ); Tue, 5 Feb 2019 08:18:15 -0500 Received: by mail-wm1-f67.google.com with SMTP id g67so3624884wmd.2 for ; Tue, 05 Feb 2019 05:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/DyMjkAoWsDa9c1Pwcmi8+O8n/FzKqeYHNqoMepo8AI=; b=y0CDmgX+aWumqlGA58FTgmJwbKf5kXDsAvC3cmmgT/zirDm1jg21NefvqQ39wE1Sw8 4XAHsZpqi1qiywPNxJ+ohmB6HG5Wpdi1x2cZa7DkVnELj6i0DC8gt6/ykphPVPH8AY9j Wr9UqkX2h23x/liVBPbDLpYazu3HcuACXnZVHu4AvbOjPFmkHPW9LfQf+v4yzADZgYZH 43B+8B9GGpWuKUzcBfULtxGRdqaBRk5qU1rM+y3uztBp/WLGS6IVsXIyCDNzFYEEgges tLjIy1NTdEiEY6+PcmJRR705r5y7Q9N0oGZ0tfnNuw2zqX2zOB33kFeAqQs4WQ+AEdxS mcag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/DyMjkAoWsDa9c1Pwcmi8+O8n/FzKqeYHNqoMepo8AI=; b=Faxz0fA+xD84ZEBwyNvOx90RuaJeUCxF8u/Ei2f0pm5qUpGxxAjMdY4pKnlv4f8jvh 1U3dCWfDyT0Cf8K1C0FiOVw46qRQk9uh7Osfc04sLRPdQbYNvAlDLTW0RlDdPHWxPN0t P9BTTAsFjssqOMqGMYGirq4/XDYZ6m21s442X0VkHe99lrAa2rLsoicesIZeNkS8IMtB rlDg48axn/fjK5yvpw1mQoYIA8KVd80lExpuZaVs4nlM0I0DxbsZef2bElY6LEdup3q6 uiG6V3P+H9+rrrCSMrs911JBCgCNuaQufH+lD62TzTuXnilGE5v2LtAjCK0A850NthPM NSmQ== X-Gm-Message-State: AHQUAua/uE496sdR+sLJaasFdnRwYw251OMNPPPKHIaZPHaDg5T9/pm9 dAX1a0Z6gdGoS/W8aBKJYOK4mvOK7JA= X-Google-Smtp-Source: AHgI3IbwAqCs0XUCEZic+oXqDOEjM+rDidp2B29vacAgrIt90vBHFcntLen/PWTINEkoFnaa6PA+Xg== X-Received: by 2002:a1c:8010:: with SMTP id b16mr3637015wmd.57.1549372693169; Tue, 05 Feb 2019 05:18:13 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id y1sm5414166wru.4.2019.02.05.05.18.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 05:18:12 -0800 (PST) Date: Tue, 5 Feb 2019 14:09:03 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net Subject: Re: [PATCH net-next v3 11/16] net: sched: track rtnl lock status when validating extensions Message-ID: <20190205130903.GH2133@nanopsycho> References: <20190204123301.4223-1-vladbu@mellanox.com> <20190204123301.4223-12-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204123301.4223-12-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 01:32:56PM CET, vladbu@mellanox.com wrote: >Actions API is already updated to not rely on rtnl lock for >synchronization. However, it need to be provided with rtnl status when >called from classifiers API in order to be able to correctly release the >lock when loading kernel module. > >Extend extension validation function with 'rtnl_held' flag which is passed >to actions API. Add new 'rtnl_held' parameter to tcf_exts_validate() in cls >API. No classifier is currently updated to support unlocked execution, so >pass hardcoded 'true' flag parameter value. > >Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko