From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106DEC282CB for ; Tue, 5 Feb 2019 13:39:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDBAA20844 for ; Tue, 5 Feb 2019 13:39:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="sKRVTScg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729370AbfBENje (ORCPT ); Tue, 5 Feb 2019 08:39:34 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37097 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728630AbfBENje (ORCPT ); Tue, 5 Feb 2019 08:39:34 -0500 Received: by mail-wm1-f68.google.com with SMTP id g67so3701841wmd.2 for ; Tue, 05 Feb 2019 05:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=O7U5sw+Ex/6iqgpihfjkqp70gTylpMoKyGysq+xx6+s=; b=sKRVTScgKd+GHdjaVEtbe2yOB36D0w8vjJXraglFDvP8Rq6BkFoQ+Es5SMnEwQi6rv boMV7XiO3L85HY1qzNR6JR5VC8UTDdWvZ+eK1WMDZ2m/gbKAcvUVJAmWtdALFN8wyfEH mlbOrvnX5MAzXLD1o5Gv1jxOeDqvl0eeL8LEfp5HgDjtsJkFI4hoMBsfWLOhOaxeI2sb XbdhTsI7NJ0QBgsitvD+oNoEDXjGi2cAPe/0ZCjB9f8QLgaY1MiMtXdyqKZ92HpNtmoE mdONBRg3cdnKUCqwHEN+No81u6BHsim+NY4/NmXL+Bw51Cw+MUSHN9Ob3jFcbrHwAj/Z +zGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=O7U5sw+Ex/6iqgpihfjkqp70gTylpMoKyGysq+xx6+s=; b=LTxG/jFtPrX1hPMRUqVNB+2rpQYtUvg2x9qxYw33bj/XGhCrBLdBDRpvH3ry1sqXBH KqjQbJ+Mjp8DOYbUVCVbKkCedDw602LpqJK/nNvnonlQm0AK7wUenRh0IRL9UjzgazLo 3PQPWCBTVFwT7/WyquXRhmed5lq0Dsuen1WPP9wsfPwFAoix2iJJ2Mdn7Pcn/WT0J7Ug x80bUW6FnyDoAoF88zw4tSClmtgbbcltVqAuXBfC8TUOGriOpwVSitqYRwhkMeOLh1H4 iUSGi1vyj1FKcEUBu4Dh6dv37xFH9fZmHeKNIk8I4PppMTtaqHJR4t0VoGS0p3u4vPla cdbA== X-Gm-Message-State: AHQUAub+DhthfiWQ0XsgggtlJqNrY0DNt26P4dFNKoUTdsxt2DUI2Ne7 IyfZiRtt2lqqTfdbhfX7hwMH4fdjb8c= X-Google-Smtp-Source: AHgI3IaskO/oNvWW7dscogRkNNJU6dzb+id1wpn6FbQ5l7ifhzOIjaXVICNnP/D21ct2L2Ij+MwXBg== X-Received: by 2002:a1c:ed17:: with SMTP id l23mr3890798wmh.51.1549373972986; Tue, 05 Feb 2019 05:39:32 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id f191sm15157557wmg.12.2019.02.05.05.39.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 05:39:32 -0800 (PST) Date: Tue, 5 Feb 2019 14:30:23 +0100 From: Jiri Pirko To: Vlad Buslov Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net Subject: Re: [PATCH net-next v3 15/16] net: sched: refactor tcf_block_find() into standalone functions Message-ID: <20190205133023.GM2133@nanopsycho> References: <20190204123301.4223-1-vladbu@mellanox.com> <20190204123301.4223-16-vladbu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204123301.4223-16-vladbu@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Feb 04, 2019 at 01:33:00PM CET, vladbu@mellanox.com wrote: >Refactor tcf_block_find() code into three standalone functions: >- __tcf_qdisc_find() to lookup Qdisc and increment its reference counter. >- __tcf_qdisc_cl_find() to lookup class. >- __tcf_block_find() to lookup block and increment its reference counter. > >This change is necessary to allow netlink tc rule update handlers to call >these functions directly in order to conditionally take rtnl lock >according to Qdisc class ops flags before calling any of class ops >functions. > >Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko