From: Stephen Hemminger <stephen@networkplumber.org>
To: Davide Caratti <dcaratti@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] tc: full JSON support for 'bpf' actions
Date: Tue, 5 Feb 2019 14:53:59 -0800 [thread overview]
Message-ID: <20190205145359.74508b0e@hermes.lan> (raw)
In-Reply-To: <c1bb8538298d24e302ef0e84ead3bfb97f2438dc.1548957196.git.dcaratti@redhat.com>
On Thu, 31 Jan 2019 18:58:09 +0100
Davide Caratti <dcaratti@redhat.com> wrote:
> + print_uint(PRINT_ANY, "code", "%hu ", ops[i].code);
> + print_uint(PRINT_ANY, "jt", "%hhu ", ops[i].jt);
> + print_uint(PRINT_ANY, "jf", "%hhu ", ops[i].jf);
Did you know that print_uint promotes the argument to unsigned int
then you are printing it with %hhu which expects only a u8.
next prev parent reply other threads:[~2019-02-05 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 17:58 [PATCH iproute2-next] tc: full JSON support for 'bpf' actions Davide Caratti
2019-02-03 17:11 ` David Ahern
2019-02-05 22:53 ` Stephen Hemminger [this message]
2019-02-05 22:59 ` David Ahern
2019-02-06 9:14 ` Davide Caratti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205145359.74508b0e@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).