From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D9BC282CB for ; Tue, 5 Feb 2019 22:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A94D42175B for ; Tue, 5 Feb 2019 22:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="fm7wFDDT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730078AbfBEWyH (ORCPT ); Tue, 5 Feb 2019 17:54:07 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:33644 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbfBEWyH (ORCPT ); Tue, 5 Feb 2019 17:54:07 -0500 Received: by mail-pf1-f195.google.com with SMTP id c123so2204795pfb.0 for ; Tue, 05 Feb 2019 14:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+15EGNm3Qf6zKNDDMRTJO2VOnCuHM2n6HHr3v7agXQw=; b=fm7wFDDT6aRGX5BZPNGTgrG/qM/6zoMZIW9Fx9JCzhbGhLj0pGohs+KlXOGj3PBAAW ehyBuc8fbe4OO9Dl8QRoJLA79Jk/y1qGsPiA9DW3zyZqkbHeO/eCbdQtLrh+zWMWZ5Lc jVKRp2iWwsWeMetezZisjLSsS8HWDBX/YokngVl3Gb9/+RyxURohDYjG13VFotTcE1N8 tVtTGk+NrZSGb1/ldxKJOGzwcGp2gGS/Ukvd8rIZYrHw0/3YrYNJlggN0wYriTvnAWL/ 2mr7g4va2I/T+U4Joz4CRHfO7+gQglP7wZPtSdo+HwnXMmkE8VTl++lTmpolDPoM/B45 1JSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+15EGNm3Qf6zKNDDMRTJO2VOnCuHM2n6HHr3v7agXQw=; b=XR0jU3vwOzuWXgndJLBgJgXTI53c/oTmObxDhrImvXWys/DnigBt26cVA/3el1u7qu F1yKKa2TrXaKdUl2jU9JKfO1Yv0xJREkAeVOEjHu8HRdmTWgNUPF7AUHQhsvgeUHYwRb JpIY8APPCr89++EHNaLO4mZmOPFzH/xYD76nZK6XNiKi9DUvhfvqmZRLaRpEQ3cbARd3 5MxfY0NmNx6EkwTcsK5I3/sFbYv81+JqEU7M4krMMBkkQrrS5MUDs5ZOFmy9E6yc2taN qc6LhUtVU5zOynNWI+RhQIv+tkgeVt0U7usWHTZPSGebVkOGkpHyHB2cu/Abr/E3cHPg IxAQ== X-Gm-Message-State: AHQUAuYpZ4Dg27fZRbs+eIHlASONdfGSSV5IsJd0PolNgifkk+h7dKfn iAkuaMVsGhLr5GvRI9geHaldnA== X-Google-Smtp-Source: AHgI3Ibd4l5nGH9uPAf+IVGIGK8fJUiJAJz6VfvKvOEOQqFdcyd3l3ajtI1JgTtNOUYWsdazhXBezg== X-Received: by 2002:a62:6047:: with SMTP id u68mr7263355pfb.239.1549407246417; Tue, 05 Feb 2019 14:54:06 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w88sm7453687pfk.11.2019.02.05.14.54.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 14:54:06 -0800 (PST) Date: Tue, 5 Feb 2019 14:53:59 -0800 From: Stephen Hemminger To: Davide Caratti Cc: David Ahern , netdev@vger.kernel.org Subject: Re: [PATCH iproute2-next] tc: full JSON support for 'bpf' actions Message-ID: <20190205145359.74508b0e@hermes.lan> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 31 Jan 2019 18:58:09 +0100 Davide Caratti wrote: > + print_uint(PRINT_ANY, "code", "%hu ", ops[i].code); > + print_uint(PRINT_ANY, "jt", "%hhu ", ops[i].jt); > + print_uint(PRINT_ANY, "jf", "%hhu ", ops[i].jf); Did you know that print_uint promotes the argument to unsigned int then you are printing it with %hhu which expects only a u8.