From: Stephen Hemminger <stephen@networkplumber.org>
To: Ido Schimmel <idosch@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dsahern@gmail.com" <dsahern@gmail.com>,
"ivecera@redhat.com" <ivecera@redhat.com>,
"liali@redhat.com" <liali@redhat.com>, mlxsw <mlxsw@mellanox.com>
Subject: Re: [PATCH iproute2-master] bridge: fdb: Fix FDB dump with strict checking disabled
Date: Tue, 5 Feb 2019 15:28:08 -0800 [thread overview]
Message-ID: <20190205152808.2f56d5c0@hermes.lan> (raw)
In-Reply-To: <20190125170837.6434-1-idosch@mellanox.com>
On Fri, 25 Jan 2019 17:09:17 +0000
Ido Schimmel <idosch@mellanox.com> wrote:
> While iproute2 correctly uses ifinfomsg struct as the ancillary header
> when requesting an FDB dump on old kernels, it sets the message type to
> RTM_GETLINK. This results in wrong reply being returned.
>
> Fix this by using RTM_GETNEIGH instead.
>
> Before:
> $ bridge fdb show brport dummy0
> Not RTM_NEWNEIGH: 00000158 00000010 00000002
>
> After:
> $ bridge fdb show brport dummy0
> 2a:0b:41:1c:92:d3 vlan 1 master br0 permanent
> 2a:0b:41:1c:92:d3 master br0 permanent
> 33:33:00:00:00:01 self permanent
> 01:00:5e:00:00:01 self permanent
>
> Fixes: 05880354c2cf ("bridge: fdb: Fix filtering with strict checking disabled")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: LiLiang <liali@redhat.com>
Looks good applied
prev parent reply other threads:[~2019-02-05 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 17:09 [PATCH iproute2-master] bridge: fdb: Fix FDB dump with strict checking disabled Ido Schimmel
2019-01-25 17:12 ` David Ahern
2019-01-25 18:00 ` Ivan Vecera
2019-02-05 23:28 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205152808.2f56d5c0@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=ivecera@redhat.com \
--cc=liali@redhat.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).