From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F76C282CB for ; Tue, 5 Feb 2019 23:28:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25A382175B for ; Tue, 5 Feb 2019 23:28:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="erblQ/kE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729152AbfBEX2M (ORCPT ); Tue, 5 Feb 2019 18:28:12 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:42811 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727320AbfBEX2M (ORCPT ); Tue, 5 Feb 2019 18:28:12 -0500 Received: by mail-pf1-f195.google.com with SMTP id 64so2222403pfr.9 for ; Tue, 05 Feb 2019 15:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LjBQuhRldI6MSB8rb/jyOos9kcDc8XNgyoDdcEEtxJM=; b=erblQ/kEKPJcR/8DfX7mLLm6OwyIHkbASBmSEVDXhtL0yorwlOwfVpPVyUt4DaM/GE /MrRnHBkZKYg4xnJKnbhO64hdAmGQ1bIQbsV/DLVp/Zc7mEfPzz5i/AQGzGHE0TCL2ZU UKdui+WeWRxCQuqwJuLv/2FEQraed9/QQNi2v/pSjfZPPfNX+TyDHvAVBV0gAPaSj2lS juaGKHnJjqeXR0tOmh7c8QSMBUgXvvj9kWzu4lx3/LtJOC+9kVkNmAM42llt+Pje+B94 svP0X71gUms1milZlSWO4xi6ct4+k/iAeOrCILtKu8LQyqd924QBU/+mmKavm5k2Wpz1 GXSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LjBQuhRldI6MSB8rb/jyOos9kcDc8XNgyoDdcEEtxJM=; b=p/vI2kb86uw8kjeCDdDhsrNylD8wrggIZEPSejA/iq/KJuaOwTsbA2hNXEjq+yHPB4 DvAzstqogbNo/9XETwYc27KKX34PhpAFQyJ9xH4GbVqcvR6FWraKZwX6IslnfMLrq6QU ohMUkoTYxSl5N14h7S4WJjA/gNfSlHs5l/ZupEEDXnUT5WFOd2risFoUSPa4d0AnQI+3 4DG42RH9PYDS4rtiFTmnIu2jcngA23P86A5MYwol6uMT3OmXu86zxIj3dPMQWF4b91p/ pdNIKCqsqIBCosgvES5j+fhj2I3aITetEdzxB5qQjXA/1fUXht40r7D6hRG2SdwrGKg/ Nebw== X-Gm-Message-State: AHQUAuax3JBfu06RBbyFiA+etWMzVemQHKZiSaZ2nOBmygO7bBeU3A7Z CBdydkKwR+2a1qwWO7D/ucJwmQ== X-Google-Smtp-Source: AHgI3IZC32YxLpv8ikPUfz110gtYpK1l0+XWqj+sD1ld3cDPaFvMPKq5qoIO2ftR11D5oCP163ihtg== X-Received: by 2002:a63:e156:: with SMTP id h22mr6842464pgk.255.1549409291402; Tue, 05 Feb 2019 15:28:11 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id m67sm5689065pfm.73.2019.02.05.15.28.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 15:28:11 -0800 (PST) Date: Tue, 5 Feb 2019 15:28:08 -0800 From: Stephen Hemminger To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "dsahern@gmail.com" , "ivecera@redhat.com" , "liali@redhat.com" , mlxsw Subject: Re: [PATCH iproute2-master] bridge: fdb: Fix FDB dump with strict checking disabled Message-ID: <20190205152808.2f56d5c0@hermes.lan> In-Reply-To: <20190125170837.6434-1-idosch@mellanox.com> References: <20190125170837.6434-1-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 25 Jan 2019 17:09:17 +0000 Ido Schimmel wrote: > While iproute2 correctly uses ifinfomsg struct as the ancillary header > when requesting an FDB dump on old kernels, it sets the message type to > RTM_GETLINK. This results in wrong reply being returned. > > Fix this by using RTM_GETNEIGH instead. > > Before: > $ bridge fdb show brport dummy0 > Not RTM_NEWNEIGH: 00000158 00000010 00000002 > > After: > $ bridge fdb show brport dummy0 > 2a:0b:41:1c:92:d3 vlan 1 master br0 permanent > 2a:0b:41:1c:92:d3 master br0 permanent > 33:33:00:00:00:01 self permanent > 01:00:5e:00:00:01 self permanent > > Fixes: 05880354c2cf ("bridge: fdb: Fix filtering with strict checking disabled") > Signed-off-by: Ido Schimmel > Reported-by: LiLiang Looks good applied