From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C5F8C282CB for ; Tue, 5 Feb 2019 16:51:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6D8420844 for ; Tue, 5 Feb 2019 16:51:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728175AbfBEQvf (ORCPT ); Tue, 5 Feb 2019 11:51:35 -0500 Received: from mx2.suse.de ([195.135.220.15]:48682 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725952AbfBEQvf (ORCPT ); Tue, 5 Feb 2019 11:51:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4D76BB01B; Tue, 5 Feb 2019 16:51:34 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 2212EE0142; Tue, 5 Feb 2019 17:51:33 +0100 (CET) Date: Tue, 5 Feb 2019 17:51:33 +0100 From: Michal Kubecek To: Vasundhara Volam Cc: Jakub Kicinski , Netdev , David Miller , "michael.chan@broadcom.com" , Jiri Pirko Subject: Re: [PATCH net-next v7 0/8] devlink: Add configuration parameters support for devlink_port Message-ID: <20190205165133.GF21401@unicorn.suse.cz> References: <1547795385-12354-1-git-send-email-vasundhara-v.volam@broadcom.com> <20190118143319.GG26670@unicorn.suse.cz> <20190122141842.26908b27@cakuba.netronome.com> <20190204185626.3c7a162b@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 05, 2019 at 09:53:26AM +0530, Vasundhara Volam wrote: > On Tue, Feb 5, 2019 at 8:26 AM Jakub Kicinski > > > > No? We were talking about using the soon-too-come ethtool netlink > > API with additional indication that given configuration request is > > supposed to be persisted. Adding more devlink parameters is exactly > > the opposite of what you should be doing. > > Okay. So, till then can we have the devlink wake_on_lan parameter or > you want this to be removed? Could you please clarify? > > Once ethtool netlink API is available with persisted support, I can remove > this wake_on_lan parameter from devlink. Thanks. Once you provide an interface for userspace and applications start using it, it's hard to get rid of it. As an extreme example, the legacy ioctl interface used by ifconfig has been declared obsolete since kernel 2.2.0 (January 1999, i.e. 20 years ago) and we still have to maintain it. Michal Kubecek