netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
	Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation
Date: Tue, 5 Feb 2019 22:29:34 +0100	[thread overview]
Message-ID: <20190205212934.GF3243@lunn.ch> (raw)
In-Reply-To: <2630352.e1UqcK5yIU@debian64>

> For now, I added the DT binding update to the patch as well.
> But if this is indeed the way to go, it'll get a separate patch.

Hi Christian 

You need to be careful with the DT binding. You need to keep backwards
compatible with it. An old DT blob needs to keep working. I don't
think this is true with this change.

      Andrew

  reply	other threads:[~2019-02-05 21:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-04 21:35 [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation Christian Lamparter
2019-02-04 22:11 ` Florian Fainelli
2019-02-04 22:26 ` Andrew Lunn
2019-02-04 23:55   ` Christian Lamparter
2019-02-05  2:45 ` Andrew Lunn
2019-02-05 12:48   ` Christian Lamparter
2019-02-05 13:09     ` Andrew Lunn
2019-02-05 21:08       ` Christian Lamparter
2019-02-05 21:29         ` Andrew Lunn [this message]
2019-02-05 22:12           ` Christian Lamparter
2019-02-05 22:29             ` Florian Fainelli
2019-02-06 21:57               ` Christian Lamparter
2019-02-06 22:29                 ` Florian Fainelli
2019-02-06 22:32                   ` Florian Fainelli
2019-02-07  0:43                   ` Christian Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190205212934.GF3243@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=chunkeey@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).