From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B10EC282CB for ; Tue, 5 Feb 2019 22:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03D7D217F9 for ; Tue, 5 Feb 2019 22:05:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AAgsN0J6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729768AbfBEWFt (ORCPT ); Tue, 5 Feb 2019 17:05:49 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:37032 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfBEWFt (ORCPT ); Tue, 5 Feb 2019 17:05:49 -0500 Received: by mail-lj1-f195.google.com with SMTP id t18-v6so4308164ljd.4 for ; Tue, 05 Feb 2019 14:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OEY26I5CbSHcC9NQUxhXUogR3dbBLTEdiroA7Y+Vgfs=; b=AAgsN0J6Y+J7D7BlCQes1L3C0BWMF6LW052R2qlrGJMyOOmfsDGg4CDvRQwzjWpDcR Fry5DA8zkKhB9NB2AoW/t2wGePiWq/mvq8FcMjc9o2cUzSmxpDS9vh5FcmwPdB5Xfxci TBF6+zYWJYkGtGiDXC9MEF+aINLHaYZL70y8z0eyStUqxAkIQUSbxR8OFGJFPKcDI/Zu o8DKWyXcpG3uXTOIaJF1HE+h84M5xx07Z90tqPs/YSznULpyQQIZvhNZSb/WduOjqdTI lva3qmtnEwp1nugHCP7LH/Dapop1viIKRHWHyEIOCfFhEJiTVuP8jH+A28KoZ67saoMw cJUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OEY26I5CbSHcC9NQUxhXUogR3dbBLTEdiroA7Y+Vgfs=; b=hG/knDyGY0Q76rNqIxZC/0Ko2DA30wipLbjZ4TI36cXNex+5PDGj4jIBF3CLWNqv/F s+KPVjTbkhmjgPU49cyEA1q5d5dBEZ3WGKg5akM4OF/VMSXAk8X+FX4y4C9LR53es1Px MpyvKOWKc0UxvkZzYA7Iy6C0Woc5GvKhx+PzkB9wUreHUn0+93YD0l2r87LxGmf4NivY vlcKgXPj1/A3do0WgFJBGLN7vFH+SniVe+mLSWzEWK6HsRnKUGntscwLavY5EV0dNWSg ZdxIGnr7824wf5SHjgxKf02ADiWBroNqzER/aMPY/XVfem9evcSehnE4+60+QGpEyOrO SeqQ== X-Gm-Message-State: AHQUAuZgpmHgLEwI87e7D3uC92V6lNTLst6u1zmfMySSV1RGmy+P11ba ZaRakIxO0Je4Y1W1R/WSXaHAkg== X-Google-Smtp-Source: AHgI3Ib+JdxDvfwFl/3qFm2xUn7vecEijfcx+XeoYHiVcf41b5d4O3oy4Ios29Y0hQabBVfvs9G5XQ== X-Received: by 2002:a2e:3218:: with SMTP id y24-v6mr4083215ljy.157.1549404346851; Tue, 05 Feb 2019 14:05:46 -0800 (PST) Received: from centauri.lan (h-229-118.A785.priv.bahnhof.se. [5.150.229.118]) by smtp.gmail.com with ESMTPSA id t19-v6sm3454987lje.23.2019.02.05.14.05.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Feb 2019 14:05:46 -0800 (PST) Date: Tue, 5 Feb 2019 23:05:44 +0100 From: Niklas Cassel To: Jose Abreu Cc: netdev@vger.kernel.org, Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , vinod.koul@linaro.org Subject: Re: [PATCH net 0/3] net: stmmac: Misc fixes Message-ID: <20190205220544.GA25400@centauri.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 30, 2019 at 03:54:18PM +0100, Jose Abreu wrote: > > Some misc fixes for stmmac targeting -net. > > Cc: Joao Pinto > Cc: David S. Miller > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > > Jose Abreu (3): > net: stmmac: Fallback to Platform Data clock in Watchdog conversion > net: stmmac: Send TSO packets always from Queue 0 > net: stmmac: Disable EEE mode earlier in XMIT callback Hello Jose, Thanks for your great work of improving the stmmac driver. Unfortunately, I'm seeing that a lot of important stmmac fixes aren't getting backported to stable kernels. I think that the problem is that a lot of stmmac commit messages do not clearly indicate what happens if these patches are not included. See netdev FAQ: Q: I have created a network patch and I think it should be backported to stable. Should I add a "Cc: stable@vger.kernel.org" like the references in the kernel's Documentation/ directory say? A: No. See above answer. In short, if you think it really belongs in stable, then ensure you write a decent commit log that describes who gets impacted by the bugfix and how it manifests itself, and when the bug was introduced. If you do that properly, then the commit will get handled appropriately and most likely get put in the patchworks stable queue if it really warrants it. Could you please tell me what happens if I don't include "net: stmmac: Disable EEE mode earlier in XMIT callback" ? likewise if I don't include "net: stmmac: Send TSO packets always from Queue 0" ? I assume that I will get a TX timeout if I try to send a TSO packet from a queue that does not support it? Also, we already define the TX queues in the snps,mtl-tx-config: Documentation/devicetree/bindings/net/stmmac.txt Wouldn't it be possible to add a snps,tso-capable property for each tx queue node that supports tso? Kind regards, Niklas > > drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 14 ++++++++++---- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 17 +++++++++++++---- > include/linux/stmmac.h | 1 + > 3 files changed, 24 insertions(+), 8 deletions(-) > > -- > 2.7.4 >