From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39033C282CB for ; Tue, 5 Feb 2019 22:28:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECCC02184E for ; Tue, 5 Feb 2019 22:28:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ucr.edu header.i=@ucr.edu header.b="GU004sNr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727717AbfBEW2F (ORCPT ); Tue, 5 Feb 2019 17:28:05 -0500 Received: from mx5.ucr.edu ([138.23.62.67]:11246 "EHLO mx5.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726606AbfBEW2F (ORCPT ); Tue, 5 Feb 2019 17:28:05 -0500 X-Greylist: delayed 694 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Feb 2019 17:28:04 EST DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1549405684; x=1580941684; h=from:to:cc:subject:date:message-id; bh=cNkg2Xb4v6zj8LUbrGCNxIBVY9mdRdd173BdKbDCchw=; b=GU004sNrJat+toEsrNjq5Ih/C/UEmrHkKn/uNojIUe22u7CvJcxqgP5j fMELH5sabRffuja852ogRz4SfbQBxjijDlE5oq0F4QQAWeDkqG9YO65bZ 6VaHnTM7dacOL6tRfu8u1UFZKOEA8ihLzFh8vZvs2yWnY7B1t65QcOoqX XJr1OYThDb3ghO5E4WKeJf8c9ZXr03g6mV1KKSHMfVlIpui4bexOPJ3lL nVDLgvHTJTwsF7pD/x001ddY4Y9kLWwTlAK+Td80ESZP0Sq2K6EZ1/hrF n5iOAWuAKEp49SXRexZt95wrY2RQwPKbmebbgKOgY1jYhIkJZEH5gJzhc A==; IronPort-PHdr: =?us-ascii?q?9a23=3AMt6bbRebCZghdVOUZ3vdH5rtlGMj4u6mDksu8pMi?= =?us-ascii?q?zoh2WeGdxcu9ZB7h7PlgxGXEQZ/co6odzbaO4+a4ASQp2tWoiDg6aptCVhsI24?= =?us-ascii?q?09vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6nK94iQPFRrhKAF7?= =?us-ascii?q?Ovr6GpLIj8Swyuu+54Dfbx9HiTahYr5+Ngm6oRnMvcQKnIVuLbo8xAHUqXVSYe?= =?us-ascii?q?RWwm1oJVOXnxni48q74YBu/SdNtf8/7sBMSar1cbg2QrxeFzQmLns65Nb3uhnZ?= =?us-ascii?q?TAuA/WUTX2MLmRdVGQfF7RX6XpDssivms+d2xSeXMdHqQb0yRD+v9LlgRgP2hy?= =?us-ascii?q?gbNj456GDXhdJ2jKJHuxKquhhzz5fJbI2JKPZye6XQfdYbRWpaRcZRVipBAoyh?= =?us-ascii?q?ZIURFuQKIOhYr4jjqFsKsBS1GA2gCe3zxjNNgHL9wK803Pk7EQze3AIuAc8Avn?= =?us-ascii?q?rXotvyL6oeTfy5wbPUwTjZc/9axTHw45XIfBA7pvGMWKp9fsjQyUguFwPFk1KQ?= =?us-ascii?q?opHiMjKV1+UNs3KU7+t8We6zhWMqsBxxrSS1xss2lIbGm58Vx0nC+C5kw4g1Pc?= =?us-ascii?q?W1RFBnbdOgCpddtCGXO5FoTs8/X21kojs2x7kEtJKjYSQHyZAqywTBZ/GJc4WE?= =?us-ascii?q?+AzvWeeLLTp6i39ofq+0iQyo/ki60OL8U9G50FNNriVYjNbBrmsN1xnP6sifTf?= =?us-ascii?q?t941uh1S6P1w/N7uFEJlg5la/BJJ4gxr48j4ITsUreEiPvlkX6kaube0c+9uin?= =?us-ascii?q?7OTnZbrmppuCOINulg7+NaEultS+AeQ+LAcOQ3CW9fqg2LDn50H0Q7VHguconq?= =?us-ascii?q?XErJzWP9kXq6q7DgNN14Ys8Re/DzOo0NQCmnkHKUpIeRKGjojpIV7OIez0Aeux?= =?us-ascii?q?jlm3jTdk2+rGMqf/DZrQM3jPiK3hcqpl605A1AozyshS55RKBbEdPf38RFHxuc?= =?us-ascii?q?fGDh82LQO02fzrCNZj2YMEX2KAHKuZPLnVsV+S6eJ8a8eWY4pAiTfvK+Uir6r/?= =?us-ascii?q?n38wmAdFJoG01oFRZXylSKc1a36FaGbh149SWVwBuRAzGam10FA=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2BNAAAGC1pcgMXSVdFlHQEBBQEHBQGBU?= =?us-ascii?q?QgBCwGDO0oPjB1fixdSBoplGG2FWYJzhQ+BewEKAQEshECDFCI0CQ0BAwEBAgE?= =?us-ascii?q?BAgETAQEJDQkIGwwxgjopgl82UoEVAQUBNVuCRwGBdA0FoQU8jBcziGIBB4FLC?= =?us-ascii?q?QEIh3CEQYEPgQeDbohTgkMCgSwBAQGKTYU7kUYBBgIBgWWBQ48LJYFsgUqGfji?= =?us-ascii?q?HWgEtmzkCBAIEBQIFDyGBJYIOTSWBbAqBRIJSjiweM4EHjXMB?= X-IPAS-Result: =?us-ascii?q?A2BNAAAGC1pcgMXSVdFlHQEBBQEHBQGBUQgBCwGDO0oPjB1?= =?us-ascii?q?fixdSBoplGG2FWYJzhQ+BewEKAQEshECDFCI0CQ0BAwEBAgEBAgETAQEJDQkIG?= =?us-ascii?q?wwxgjopgl82UoEVAQUBNVuCRwGBdA0FoQU8jBcziGIBB4FLCQEIh3CEQYEPgQe?= =?us-ascii?q?DbohTgkMCgSwBAQGKTYU7kUYBBgIBgWWBQ48LJYFsgUqGfjiHWgEtmzkCBAIEB?= =?us-ascii?q?QIFDyGBJYIOTSWBbAqBRIJSjiweM4EHjXMB?= X-IronPort-AV: E=Sophos;i="5.58,337,1544515200"; d="scan'208";a="26788390" Received: from mail-pf1-f197.google.com ([209.85.210.197]) by smtpmx5.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 05 Feb 2019 14:16:14 -0800 Received: by mail-pf1-f197.google.com with SMTP id t2so3652584pfj.15 for ; Tue, 05 Feb 2019 14:16:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pRKoSfdwVwNdyz3mDpwMRoy9Lm16c1WzLiKmYaYvmpE=; b=ljyALFQtYj869c8BgliWhvoQHgD0yVgXfTBvD7iIRavyUf6sgf9R7Y9is8fuN1Wbh4 cvqell5ygAdpPu7BlxwUrf4QEFaogJRZzIwNZrCP7TP4yFum1xwUc/71rZKNzAuS0cFa oiQEEAyb0szPljKobR/292x431VlYq3aFYhjUeNjWRjIqQRYnp5LNHIXSJOBXkmfEljc ouO0rPmdNAMl6QTAY4n+jycFIaQkAON/UoEdPlcQADam0JAr9iPHmWIM3SR55TI2pecx AWV6mQqSZkLEQKYGMi41+DT+xjOjY5ZxoZxuOku33rWXgZ3gL8JaYu5+sPt+L/BmFPau wYlQ== X-Gm-Message-State: AHQUAuZ/trqkcO9ye/Tcfh2xJymT856WkVxixTQnd67AbAxI8bH+2amf ZW0DDH/XBjL/DGtyomj/kDetnhkZZNlBTaLdNVF6q4hhsuJ/DVwSW+rmT6f2ci9Yf4hVlP3IEhj iBm1ya60f4gzsWS/rPg== X-Received: by 2002:a63:571f:: with SMTP id l31mr3789823pgb.91.1549404974101; Tue, 05 Feb 2019 14:16:14 -0800 (PST) X-Google-Smtp-Source: AHgI3IZCsiMpsIK6rGFrgQ8DS7SKjLCGYc9FvgfZmMIbuVkDRAGCjMCY6cD2q1+TJ8D5jJk+fQPLNQ== X-Received: by 2002:a63:571f:: with SMTP id l31mr3789795pgb.91.1549404973698; Tue, 05 Feb 2019 14:16:13 -0800 (PST) Received: from Yizhuo.cs.ucr.edu (yizhuo.cs.ucr.edu. [169.235.26.74]) by smtp.googlemail.com with ESMTPSA id d13sm8942729pfd.58.2019.02.05.14.16.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 14:16:12 -0800 (PST) From: Yizhuo Cc: csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo , Giuseppe Cavallaro , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: stmmac: Variable "val" in function sun8i_dwmac_set_syscon() could be uninitialized Date: Tue, 5 Feb 2019 14:15:59 -0800 Message-Id: <20190205221559.17545-1-yzhai003@ucr.edu> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In function sun8i_dwmac_set_syscon(), local variable "val" could be uninitialized if function regmap_read() returns -EINVAL. However, it will be used directly in the if statement, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c index 39c2122a4f26..11d481c9e7ab 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c @@ -639,9 +639,14 @@ static int sun8i_dwmac_set_syscon(struct stmmac_priv *priv) struct sunxi_priv_data *gmac = priv->plat->bsp_priv; struct device_node *node = priv->device->of_node; int ret; - u32 reg, val; + u32 reg, val = 0; + + ret = regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); + if (ret) { + dev_err(priv->device, "Fail to read SYSCON_EMAC_REG.\n"); + return ret; + } - regmap_read(gmac->regmap, SYSCON_EMAC_REG, &val); reg = gmac->variant->default_syscon_value; if (reg != val) dev_warn(priv->device, -- 2.17.1