From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D73FC169C4 for ; Wed, 6 Feb 2019 19:59:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D000218B0 for ; Wed, 6 Feb 2019 19:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727070AbfBFT7L (ORCPT ); Wed, 6 Feb 2019 14:59:11 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:34860 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbfBFT7K (ORCPT ); Wed, 6 Feb 2019 14:59:10 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C08661400C9AD; Wed, 6 Feb 2019 11:59:09 -0800 (PST) Date: Wed, 06 Feb 2019 11:59:09 -0800 (PST) Message-Id: <20190206.115909.1678532321505448811.davem@davemloft.net> To: rmk+kernel@armlinux.org.uk Cc: andrew@lunn.ch, gregory.clement@bootlin.com, jason@lakedaemon.net, kishon@ti.com, sebastian.hesselbarth@gmail.com, thomas.petazzoni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/6] phy: armada38x: add common phy support From: David Miller In-Reply-To: References: <20190206113409.ko7lwuv5kb7l7rjo@shell.armlinux.org.uk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Feb 2019 11:59:10 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Russell King Date: Wed, 06 Feb 2019 11:34:52 +0000 > +static int a38x_comphy_probe(struct platform_device *pdev) > +{ > + struct a38x_comphy *priv; > + struct phy_provider *provider; > + struct device_node *child; > + struct resource *res; > + void __iomem *base; Reverse christmas tree here please. Thanks.