From: David Miller <davem@davemloft.net>
To: ilias.apalodimas@linaro.org
Cc: alexandre.torgue@st.com, peppe.cavallaro@st.com,
mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
joabreu@synopsys.com
Subject: Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4
Date: Wed, 06 Feb 2019 17:28:41 -0800 (PST) [thread overview]
Message-ID: <20190206.172841.19020410876653677.davem@davemloft.net> (raw)
In-Reply-To: <1549368920-1989-1-git-send-email-ilias.apalodimas@linaro.org>
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: Tue, 5 Feb 2019 14:15:20 +0200
> The current driver only enables Pdelay_Req and Pdelay_Resp when
> HWTSTAMP_FILTER_PTP_V2_EVENT, HWTSTAMP_FILTER_PTP_V1_L4_EVENT or
> HWTSTAMP_FILTER_PTP_V2_L4_EVENT is requested. This results in ptp sync on
> slave mode to report 'received SYNC without timestamp' when using ptp4l.
>
> Although the hardware can support Sync, Pdelay_Req and Pdelay_resp by
> setting bit14 annd bits 17/16 to 01 this leaves Delay_Req timestamps out.
>
> Fix this by enabling all event and general messages timestamps.
> This includes SYNC, Follow_Up, Delay_Req, Delay_Resp, Pdelay_Req,
> Pdelay_Resp and Pdelay_Resp_Follow_Up messages.
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Applied to net-next, thanks.
prev parent reply other threads:[~2019-02-07 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 12:15 [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4 Ilias Apalodimas
2019-02-06 11:45 ` Jose Abreu
2019-02-06 12:56 ` Alexandre Torgue
2019-02-07 1:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206.172841.19020410876653677.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=ilias.apalodimas@linaro.org \
--cc=joabreu@synopsys.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).