From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7476FC169C4 for ; Thu, 7 Feb 2019 01:28:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E4A5217F9 for ; Thu, 7 Feb 2019 01:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbfBGB2m (ORCPT ); Wed, 6 Feb 2019 20:28:42 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:39102 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbfBGB2m (ORCPT ); Wed, 6 Feb 2019 20:28:42 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E212614049752; Wed, 6 Feb 2019 17:28:41 -0800 (PST) Date: Wed, 06 Feb 2019 17:28:41 -0800 (PST) Message-Id: <20190206.172841.19020410876653677.davem@davemloft.net> To: ilias.apalodimas@linaro.org Cc: alexandre.torgue@st.com, peppe.cavallaro@st.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, joabreu@synopsys.com Subject: Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4 From: David Miller In-Reply-To: <1549368920-1989-1-git-send-email-ilias.apalodimas@linaro.org> References: <1549368920-1989-1-git-send-email-ilias.apalodimas@linaro.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Feb 2019 17:28:42 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ilias Apalodimas Date: Tue, 5 Feb 2019 14:15:20 +0200 > The current driver only enables Pdelay_Req and Pdelay_Resp when > HWTSTAMP_FILTER_PTP_V2_EVENT, HWTSTAMP_FILTER_PTP_V1_L4_EVENT or > HWTSTAMP_FILTER_PTP_V2_L4_EVENT is requested. This results in ptp sync on > slave mode to report 'received SYNC without timestamp' when using ptp4l. > > Although the hardware can support Sync, Pdelay_Req and Pdelay_resp by > setting bit14 annd bits 17/16 to 01 this leaves Delay_Req timestamps out. > > Fix this by enabling all event and general messages timestamps. > This includes SYNC, Follow_Up, Delay_Req, Delay_Resp, Pdelay_Req, > Pdelay_Resp and Pdelay_Resp_Follow_Up messages. > > Signed-off-by: Ilias Apalodimas Applied to net-next, thanks.