From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 376E3C282C2 for ; Thu, 7 Feb 2019 01:43:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1003B2081B for ; Thu, 7 Feb 2019 01:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbfBGBnW (ORCPT ); Wed, 6 Feb 2019 20:43:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:39368 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbfBGBnV (ORCPT ); Wed, 6 Feb 2019 20:43:21 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 226221403ED46; Wed, 6 Feb 2019 17:43:21 -0800 (PST) Date: Wed, 06 Feb 2019 17:43:20 -0800 (PST) Message-Id: <20190206.174320.1855986692811593722.davem@davemloft.net> To: albin_yang@163.com Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com, yang.wei9@zte.com.cn Subject: Re: [PATCH net] net: via-velocity: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles From: David Miller In-Reply-To: <1549383774-5726-1-git-send-email-albin_yang@163.com> References: <1549383774-5726-1-git-send-email-albin_yang@163.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Feb 2019 17:43:21 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yang Wei Date: Wed, 6 Feb 2019 00:22:54 +0800 > From: Yang Wei > > dev_consume_skb_irq() should be called in velocity_free_tx_buf() > when skb xmit done. It makes drop profiles(dropwatch, perf) more > friendly. > > Signed-off-by: Yang Wei Applied.