From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC0DC282C2 for ; Thu, 7 Feb 2019 03:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 377CD2073D for ; Thu, 7 Feb 2019 03:47:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbfBGDrK (ORCPT ); Wed, 6 Feb 2019 22:47:10 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:40276 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbfBGDrK (ORCPT ); Wed, 6 Feb 2019 22:47:10 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D892714017AC1; Wed, 6 Feb 2019 19:47:09 -0800 (PST) Date: Wed, 06 Feb 2019 19:47:06 -0800 (PST) Message-Id: <20190206.194706.397183399531687599.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: phy: improve genphy_c45_read_link From: David Miller In-Reply-To: <303235da-0957-32bb-29ff-014c85b93f72@gmail.com> References: <303235da-0957-32bb-29ff-014c85b93f72@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 06 Feb 2019 19:47:10 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Tue, 5 Feb 2019 20:41:37 +0100 > Let's make genphy_c45_read_link behave the same as genphy_update_link > and set phydev->link in the function directly. This allows to simplify > the callers. In addition don't check further devices once we detect > that at least one device reports link as down. > > v2: > - remove an unused variable > > Signed-off-by: Heiner Kallweit Applied, thanks Heiner.