From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
linville@tuxdriver.com,
Nicholas Nunley <nicholas.d.nunley@intel.com>,
nhorman@redhat.com, sassmann@redhat.com
Subject: Re: [PATCH v2 3/6] ethtool: introduce new ioctl for per-queue settings
Date: Wed, 6 Feb 2019 11:32:58 +0100 [thread overview]
Message-ID: <20190206103258.GK21401@unicorn.suse.cz> (raw)
In-Reply-To: <20190206000106.24364-3-jeffrey.t.kirsher@intel.com>
On Tue, Feb 05, 2019 at 04:01:03PM -0800, Jeff Kirsher wrote:
> +static int find_max_num_queues(struct cmd_context *ctx)
> +{
> + struct ethtool_channels echannels;
> +
> + echannels.cmd = ETHTOOL_GCHANNELS;
> + if (send_ioctl(ctx, &echannels))
> + return -1;
> +
> + return MAX(MAX(echannels.rx_count, echannels.tx_count),
> + echannels.combined_count);
> +}
Is the outer MAX() correct here? From the documentation to -L option, it
rather seems we might want
return MAX(echannels.rx_count, echannels.tx_count) +
echannels.combined_count;
But I can't find any NIC around which would have non-zero rx_count or
tx_count so that I cannot check.
Michal Kubecek
next prev parent reply other threads:[~2019-02-06 10:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 0:01 [PATCH v2 1/6] ethtool: move option parsing related code into function Jeff Kirsher
2019-02-06 0:01 ` [PATCH v2 2/6] ethtool: move cmdline_coalesce out of do_scoalesce Jeff Kirsher
2019-02-06 0:01 ` [PATCH v2 3/6] ethtool: introduce new ioctl for per-queue settings Jeff Kirsher
2019-02-06 9:18 ` Michal Kubecek
2019-02-07 23:37 ` Nunley, Nicholas D
2019-02-08 7:02 ` Michal Kubecek
2019-02-08 13:56 ` Willem de Bruijn
2019-02-06 10:32 ` Michal Kubecek [this message]
2019-02-07 23:41 ` Nunley, Nicholas D
2019-02-06 12:43 ` Michal Kubecek
2019-02-07 23:43 ` Nunley, Nicholas D
2019-02-06 0:01 ` [PATCH v2 4/6] ethtool: support per-queue sub command --show-coalesce Jeff Kirsher
2019-02-06 13:22 ` Michal Kubecek
2019-02-07 23:53 ` Nunley, Nicholas D
2019-02-08 7:10 ` Michal Kubecek
2019-02-06 0:01 ` [PATCH v2 5/6] ethtool: support per-queue sub command --coalesce Jeff Kirsher
2019-02-06 0:01 ` [PATCH v2 6/6] ethtool: fix up dump_coalesce output to match actual option names Jeff Kirsher
2019-02-06 9:56 ` [PATCH v2 1/6] ethtool: move option parsing related code into function Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206103258.GK21401@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=nicholas.d.nunley@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox