From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE527C282C2 for ; Wed, 6 Feb 2019 18:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4E60206DD for ; Wed, 6 Feb 2019 18:53:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="bM/quxCW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727871AbfBFSxH (ORCPT ); Wed, 6 Feb 2019 13:53:07 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:43063 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727986AbfBFSv3 (ORCPT ); Wed, 6 Feb 2019 13:51:29 -0500 Received: by mail-pl1-f195.google.com with SMTP id gn14so3490641plb.10 for ; Wed, 06 Feb 2019 10:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HZWf/RYuQsur5zRracR5UyqQlF+LZFZkzmFQEl7TYG4=; b=bM/quxCWEyFpIrFIecMUtexXZevsASVC7REjCUpDjDXKaqEjZVw2oRLaonxZqG3Z+p omErA7m4ZqRoYeb+2iwCE3DMiZTDqAA5IXtHink8IG5WLpnw43MutSUuc2UsM1SjrS/f F2HE8VUJQFIHdyj5lny0uO7SpkNzGYNZhgstktO/XFuUNlnK4WdsKyLfY/cu/kSSfkP2 VhmGwXBo4h/Pg63lETPFJAW0Pyytr9hKYGrnn7Oo5c3ZEREGGRlp6i1atYPeBziqJdtK BMi2k87fqEDgo3TXnsf4J7W2iz2AMfsb553Cq5z7yAQPsiJIPXQ7wJ37U27vLplwOpYJ HAVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HZWf/RYuQsur5zRracR5UyqQlF+LZFZkzmFQEl7TYG4=; b=XdicR5z+GLDmtxjnrdDK06L19UwR2tO1Uis9T09m4qdSDxL5Mr4hBHyL2fZlnQWSDX PIpkpA4UR15N+J3IC1KqW/37jJS8KSpXwaV51HO9Pm9y4Q4A2tFOAHmPeLhTZvCKtyRd NKoWMMWeWZPJ34avnOq9RxyzjOKgIbYvXuAURy8xibRuAyrpAEmeO/XBLMAOC/PFGF8h 3n3SQzLAUdrQi4Z2C7YoiVK/b8zbmNZDdOGO/YXXGTeXj8qPL7RWY/p7Z3CNa54mvSMv Y2qtW921Zq8wBQqoJa8t60EdPsqo5iFqYhBkN/32lcW10QonaKXMCYQRUFc9IYNmmkHz w2mQ== X-Gm-Message-State: AHQUAuZ1Hskw6vNAcxtm1Anl1s6+S9xcJ2z0xi8B6c+golxz2DRzO/z2 x5cfTiWOWcTqf9wQD3crdO+7/GOwDwY= X-Google-Smtp-Source: AHgI3IahqhvLlzIrtS4HB4ITnpEXt2rOAj5+khesCKCZXvPNT4/AH1d9W6H2LFoicu620Gwyj5kURg== X-Received: by 2002:a17:902:7e0d:: with SMTP id b13mr12302042plm.154.1549479089203; Wed, 06 Feb 2019 10:51:29 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k129sm8398919pgk.29.2019.02.06.10.51.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 10:51:29 -0800 (PST) Date: Wed, 6 Feb 2019 10:51:26 -0800 From: Stephen Hemminger To: Marcos Antonio Moraes Cc: netdev@vger.kernel.org Subject: Re: [PATCH] Using rates in bits when limits are specified in % Message-ID: <20190206105126.0d147d72@hermes.lan> In-Reply-To: <20190206180913.19381-1-marcos.antonio@digirati.com.br> References: <20190206180913.19381-1-marcos.antonio@digirati.com.br> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 6 Feb 2019 16:09:13 -0200 Marcos Antonio Moraes wrote: > As /sys/class/net//speed indicates a value in Mbits/sec, the > transformation is necessary to create the correct limitations. Not sure, if this is correct or not could you give an example? This patch needs a signed-off-by and a a Fixes tag. Also please put iproute2 in subject line: [PATCH iproute2] tc: use bits not mbits/sec in rate percent. Also, please rebase since I just found a memory leak in this function.