From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 114D4C169C4 for ; Wed, 6 Feb 2019 10:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD3B0217F9 for ; Wed, 6 Feb 2019 10:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728341AbfBFKzf (ORCPT ); Wed, 6 Feb 2019 05:55:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56804 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727896AbfBFKzf (ORCPT ); Wed, 6 Feb 2019 05:55:35 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1BAE63DE0E; Wed, 6 Feb 2019 10:55:31 +0000 (UTC) Received: from localhost (ovpn-200-19.brq.redhat.com [10.40.200.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C44705C207; Wed, 6 Feb 2019 10:55:26 +0000 (UTC) Date: Wed, 6 Feb 2019 11:55:22 +0100 From: Stefano Brivio To: Stephen Hemminger , David Ahern Cc: Roopa Prabhu , Nikolay Aleksandrov , Phil Sutter , Eric Garver , Tomas Dolezal , Lennert Buytenhek , netdev Subject: Re: [PATCH iproute2-next] Introduce ip-brctl shell script Message-ID: <20190206115522.3843a125@redhat.com> In-Reply-To: <20190205145033.5d90dc42@hermes.lan> References: <800cb3d3-c749-3f36-83ea-0375e67fbd33@cumulusnetworks.com> <20190125110543.35693aee@elisabeth> <20190128085748.57cbeff5@redhat.com> <20190131134606.4be7f205@redhat.com> <20190205145033.5d90dc42@hermes.lan> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 06 Feb 2019 10:55:35 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 5 Feb 2019 14:50:33 -0800 Stephen Hemminger wrote: > Providing brctl or ifconfig scripts is possible, but it really should > be put in a sample or demo directory and not installed by default. > It would just cause too much pain to distributions. On one hand, I did it this way exactly to make it easy for distributions (after all, I work for a distributor). The rationale is that it's easier to get rid of things from package scripts rather than add them. Also implementing a Debian package diversion looked more elegant this way. No idea about other ones though. On the other hand, I didn't even think of adding that to examples/. Maybe that would alleviate David's concern about having to maintain it forever (if it breaks temporarily, or if we need to remove it for some reason, it's not a drama). > I love concise human readable output and hate long winded VMS style > commands. That's exactly where I feel the current tools included in iproute2 fall rather short. Compare "brctl show" to the closest equivalent "IFS=' ' for b in $(ip -br link show type bridge); do ip -br link show type bridge_slave master ${b%% *}; done". Sure, as Roopa said, we could and should improve 'bridge', and by now I'm even almost convinced it's doable without breaking the existing syntax, but it's not something we're doing overnight. -- Stefano