From: Thierry Reding <thierry.reding@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Joe Perches <joe@perches.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Paul Zimmerman <pauldzim@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] r8169: Load MAC address from device tree if present
Date: Wed, 6 Feb 2019 13:33:55 +0100 [thread overview]
Message-ID: <20190206123355.GD21676@ulmo> (raw)
In-Reply-To: <20190206123018.24802-1-thierry.reding@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Wed, Feb 06, 2019 at 01:30:17PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> If the system was booted using a device tree and if the device tree
> contains a MAC address, use it instead of reading one from the EEPROM.
> This is useful in situations where the EEPROM isn't properly programmed
> or where the firmware wants to override the existing MAC address.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Applies on net-next.
>
> Changes in v2:
> - rewrite error check for readability
> - initialize mac_addr array
>
> drivers/net/ethernet/realtek/r8169.c | 36 ++++++++++++++++++----------
> 1 file changed, 23 insertions(+), 13 deletions(-)
Sorry, I forgot to include Heiner's Reviewed-by tag here, but with any
luck patchwork will pick it up if I do this:
This patch previously:
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-06 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 12:30 [PATCH v3 1/2] r8169: Load MAC address from device tree if present Thierry Reding
2019-02-06 12:30 ` [PATCH v3 2/2] r8169: Avoid pointer aliasing Thierry Reding
2019-02-06 12:35 ` Thierry Reding
2019-02-06 13:28 ` Andrew Lunn
2019-02-06 21:40 ` David Miller
2019-02-06 12:33 ` Thierry Reding [this message]
2019-02-06 13:29 ` [PATCH v3 1/2] r8169: Load MAC address from device tree if present Andrew Lunn
2019-02-06 21:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206123355.GD21676@ulmo \
--to=thierry.reding@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pauldzim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).