From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A63C169C4 for ; Wed, 6 Feb 2019 17:48:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BD022073D for ; Wed, 6 Feb 2019 17:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a0i0hV5g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728658AbfBFRsa (ORCPT ); Wed, 6 Feb 2019 12:48:30 -0500 Received: from mail-qt1-f175.google.com ([209.85.160.175]:38636 "EHLO mail-qt1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727299AbfBFRs3 (ORCPT ); Wed, 6 Feb 2019 12:48:29 -0500 Received: by mail-qt1-f175.google.com with SMTP id 2so8835209qtb.5; Wed, 06 Feb 2019 09:48:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=xnDMFj0aLXa3hngPSBRX5BRktD3AozJOivMDHbO2w+o=; b=a0i0hV5gVSzW1GuTYH+D9t2rYJmw1Kyhre1ewzu+qssF7jQb6GejeWhSqnqb8rEZnB UnTV3sudA9EbKD76oSDHA7BXOLMxQAaZ5WH1RqIN6EwFLsUBLRmTXcbjIuZqR8dm/wIg 9ZanD4hKSOnkV/LqD9moMR5JDy0iwfqJaY8+pk75Pi5WG5lbX0xcd5WTmjC+tLBg2M9O 4il9RgM87Nc3VAormN1p0pTAUA7nhdH1SW56IqquPN7pAcwlPra6mgri0hppnSTpFkJ9 wR5SfSQFoRbwN5LrvQDrrD5y3cdTC99SLNl/GV/T8VmsSFwK01HndPTZfasJx05rNQr5 lMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=xnDMFj0aLXa3hngPSBRX5BRktD3AozJOivMDHbO2w+o=; b=UQhfOiS9aSQN2NchEH8hbcAlfa9OG/E9qO1rup2NrPle2zqSMXMEXJZoNhN3oJBPJm hhqZKTRZVjBAS8I3kC4UHyWQPkqADke9dbodh5EHVIZljEsMdHO9OntG598sydeuikjn A0C9OT1l71xL6Dy5Nmg0J4w0TFlsv6IaNcbozmh+GjtkLS+M3Mv/TNnXbmjvUnAkJTPF VvRPKXGfna5neY4TEBLD28Oi3qMBmRpEjrIgyZ1wASqxrPUOxaR5WDr5p0guNOY4wkwm RGxka27FCNPPYeTbrDhR8oyffTHXkunVfOOvxO6gN3bFfZSZz8Ukx8uMKQOkfziGr4SQ ykBg== X-Gm-Message-State: AHQUAubOCPfUl39GX9y+0PALK/lA52gAYVMWLtvcXjfSEa+BaIQyq/yL w6zSm+EzsvFBeX+aDfxHG9rdvPMA X-Google-Smtp-Source: AHgI3IbR6Z516lnY3X0CsQpoPTLcHuccAOoJhUQjM0CBuygkB+ZYCO6WeOef9VqNNwYIthxBewVKig== X-Received: by 2002:ac8:296a:: with SMTP id z39mr8767432qtz.264.1549475308497; Wed, 06 Feb 2019 09:48:28 -0800 (PST) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id o34sm16256614qte.4.2019.02.06.09.48.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 09:48:27 -0800 (PST) Date: Wed, 6 Feb 2019 12:48:26 -0500 Message-ID: <20190206124826.GB9278@t480s.localdomain> From: Vivien Didelot To: Dan Carpenter Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] net: dsa: Fix NULL checking in dsa_slave_set_eee() In-Reply-To: <20190206153514.GA11033@kadam> References: <20190206153514.GA11033@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 6 Feb 2019 18:35:15 +0300, Dan Carpenter wrote: > This function can't succeed if dp->pl is NULL. It will Oops inside the > call to return phylink_ethtool_get_eee(dp->pl, e); > > Fixes: 1be52e97ed3e ("dsa: slave: eee: Allow ports to use phylink") > Signed-off-by: Dan Carpenter Reviewed-by: Vivien Didelot