From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C16AC169C4 for ; Wed, 6 Feb 2019 13:09:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCCCD2175B for ; Wed, 6 Feb 2019 13:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="NM7AywVY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728641AbfBFNJC (ORCPT ); Wed, 6 Feb 2019 08:09:02 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37927 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727080AbfBFNI6 (ORCPT ); Wed, 6 Feb 2019 08:08:58 -0500 Received: by mail-wr1-f65.google.com with SMTP id v13so7479320wrw.5 for ; Wed, 06 Feb 2019 05:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=P1pOlZW/Id97sp4fAA+2r0hhEC/TTJ/UW1DX4h/o9vI=; b=NM7AywVY9VILtjTRV+wZ2glv9suyd8bMBHvMpU3wbOuGOuHq11V17x8MK3F3th7nMa kc7plOaf1EPCWaKUlLhsJouiWGFZqpw5mzpyCJW8IwH1kqkYETS8Dq4rqeLeHrzb8ix9 QCiIhqXrfhmmF5YaML4XcIK7TY3qDkfNjslpyzNoLo3Dqxg7tyd2G03Yk7tOXRk9vdHE EjcPgALv1c+NEU6DA6u3K1th+9kBnEGECABsKpWkGKkbNelI3NN8jT8206CutE8yM3+J 6XQLLa+Q81yeE62lK6PRfgHgufr1wXOsBtrql6eKwGulanOowtiDZ5ctpQpfUWgr3dMW 5EsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=P1pOlZW/Id97sp4fAA+2r0hhEC/TTJ/UW1DX4h/o9vI=; b=U+9EkqqXUV9Hr/M+AhKq3wM612etIO6n4PnpNLxDPFh5yZ9hqklEi/b3MdZ4JEFuaB XsaHX0QUK+hszadzUCX6XVSNBOuekmBWcSvp0KmR1ijYyh8u2s5En27jkqdvsmHWp2Fw ECydSV8l7FhvZ4Rr31ysAJ4AFuWCWJeRj1Kk74oYWALpd4jccubLqkLnVzw5CKLJuTjC mFT0w7P56IpfJEl+VxW7PxcEe5KM9MQw1Zg8MQby7krSSNIsYeoonN3RBbZYaqHvSwqw x3Fuc4M3n22pGl5rxpQ+U6QbZkOPnRxADOOghDH0f0wsHVmpPK3mqGw/3VmmJn+MJ1N2 d9Sg== X-Gm-Message-State: AHQUAubi15kGgI7S9IyHmIrjQdsAojYmBmjTZLb2UeHhHE4c9/3rJN/x 9CLrWU7KWsOF6woTM18uVSiJxA== X-Google-Smtp-Source: AHgI3Ib3/nnzT6S8FH7jrpgXBr97s3NRqV1YTUtTkm3Qo2BHAMOtkSh7KMiCvrf8+KV9bqmPals0xQ== X-Received: by 2002:adf:f401:: with SMTP id g1mr8100652wro.103.1549458536006; Wed, 06 Feb 2019 05:08:56 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id q12sm18603496wrx.31.2019.02.06.05.08.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 05:08:55 -0800 (PST) Date: Wed, 6 Feb 2019 13:59:44 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, "David S. Miller" , Ido Schimmel , open list , "open list:MELLANOX MLX5 core VPI driver" , "open list:NETRONOME ETHERNET DRIVERS" , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next v3 02/12] bnxt: Implement ndo_get_port_parent_id() Message-ID: <20190206125944.GC2189@nanopsycho> References: <20190205235326.14600-1-f.fainelli@gmail.com> <20190205235326.14600-3-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190205235326.14600-3-f.fainelli@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Feb 06, 2019 at 12:53:16AM CET, f.fainelli@gmail.com wrote: >BNXT only supports SWITCHDEV_ATTR_ID_PORT_PARENT_ID, which makes it a >great candidate to be converted to use the ndo_get_port_parent_id() NDO >instead of implementing switchdev_port_attr_get(). The conversion is >straight forward here since the PF and VF code use the same getter. > >Since bnxt makes uses of switchdev_port_same_parent_id() convert it to >use netdev_port_same_parent_id(). > >Signed-off-by: Florian Fainelli [...] >diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c >index c683b5e96b1d..170d2fbbb91b 100644 >--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c >+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c >@@ -12,6 +12,7 @@ > #include > #include > #include >+#include You don't need this. Looks like a leftover. Otherwise, looks fine. Acked-by: Jiri Pirko > #include > #include > #include [...]