From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC4BC169C4 for ; Wed, 6 Feb 2019 13:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFE8420823 for ; Wed, 6 Feb 2019 13:23:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="GZBCzfI/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731113AbfBFNXz (ORCPT ); Wed, 6 Feb 2019 08:23:55 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39998 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730941AbfBFNXv (ORCPT ); Wed, 6 Feb 2019 08:23:51 -0500 Received: by mail-wr1-f68.google.com with SMTP id p4so7526806wrt.7 for ; Wed, 06 Feb 2019 05:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R3MAd8ERATstMVf6jvlrx6LGkVnckuqZbN5JPFSgo0g=; b=GZBCzfI/ez5EkqElnQvm26Kol78TP0TlacDUtKht9wCO1LNxJPZOWQyH2id1ErSxOW YOFakguaBHbsOVsql+id60OsEBCjegGRkS2zikVvNYaIb+phCNALsTc5iRRmGiokGmZL PT/hbQJMIz8Lo9abaf7QbgiQ6z2BpLI0+0qe1otpfAOQOelGNyoCLEVSxfkLSSsS9Zf+ 5Gu1uw+rXUgsLcoOjQAKJn+KpgHtZDrnFzzm6jaaRa8lDRugfVzoCMoVt68+DesJsS9t KphyfUHMkQVbBz7mSBwi+PfABVxQo7dW3ILVr+q5JZBoyNlNl+D40f8UjKlu1AbGVNkQ SZYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R3MAd8ERATstMVf6jvlrx6LGkVnckuqZbN5JPFSgo0g=; b=PzWgNlOZeb4aNbSSwJWo5VcS9QFEhoL3Y3bwII+abuyHWx6eohTNvbYNLuC1x/Flxg r5oyNWQOLNq1ybhfhg5w3jYABgDUi5EYyJMwToKgkjSTpt00i4N0WgO6w/DGyc1KG7lL w203ZahxvBt2mFNNZfvNAwHwL41g5fJQGpl1D93DETYa4KTKktDYpw6dxpR4iW7WrZuj WTtkvV+bvkNq+xm1M2uQuK7UYlQUu19qd4/z7pZUGCexWznGbjb6gmMTz16Umu6PeaUd JMqRpfS8SCQFqL18H+FbCnqngrApEwmdpgQU9L+iwCTYURorLt6+y34SOCdSuEWL8PEl OX2g== X-Gm-Message-State: AHQUAubiHmYNctRaTR3B0keZvEPSaVStl1GJKYcsrpQJvj+wsOxqb/jH efQoXpAZSgWHdtPQY2XI6NLEgA== X-Google-Smtp-Source: AHgI3IYM1zKwtTgPLpbLdqYmprvA92RbadBepxocK6TVaG9gSCYaaHufSFo0LxE6vulEVM5ua91ULw== X-Received: by 2002:adf:891a:: with SMTP id s26mr7886737wrs.44.1549459430017; Wed, 06 Feb 2019 05:23:50 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id x22sm6475472wmj.40.2019.02.06.05.23.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Feb 2019 05:23:49 -0800 (PST) Date: Wed, 6 Feb 2019 14:14:38 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, "David S. Miller" , Ido Schimmel , open list , "open list:MELLANOX MLX5 core VPI driver" , "open list:NETRONOME ETHERNET DRIVERS" , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" Subject: Re: [PATCH net-next v3 05/12] mlxsw: Implement ndo_get_port_parent_id() Message-ID: <20190206131438.GF2189@nanopsycho> References: <20190205235326.14600-1-f.fainelli@gmail.com> <20190205235326.14600-6-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190205235326.14600-6-f.fainelli@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Feb 06, 2019 at 12:53:19AM CET, f.fainelli@gmail.com wrote: >mlxsw implements SWITCHDEV_ATTR_ID_PORT_PARENT_ID and we want to get rid >of switchdev_ops eventually, ease that migration by implementing a >ndo_get_port_parent_id() function which returns what >switchdev_port_attr_get() would do. > >Signed-off-by: Florian Fainelli [...] >diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c >index 2d4f213e154d..3814ba8af517 100644 >--- a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c >+++ b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c Please remove net/switchdev.h inclusion from this file, you don't need it any longer. Otherwise, looks fine. Acked-by: Jiri Pirko [...]