From: Andrew Lunn <andrew@lunn.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Joe Perches <joe@perches.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Paul Zimmerman <pauldzim@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] r8169: Avoid pointer aliasing
Date: Wed, 6 Feb 2019 14:28:16 +0100 [thread overview]
Message-ID: <20190206132816.GD20405@lunn.ch> (raw)
In-Reply-To: <20190206123018.24802-2-thierry.reding@gmail.com>
On Wed, Feb 06, 2019 at 01:30:18PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Read MAC address 32-bit at a time and manually extract the individual
> bytes. This avoids pointer aliasing and gives the compiler a better
> chance of optimizing the operation.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Applies to net-next.
>
> I tested this on a Jetson TX2 with an add-in Realtek ethernet card that
> has a properly programmed OTP to verify that I got the endianess right.
> Seems like everything works and the device behaves the same with or
> without this patch.
>
> Changes in v3:
> - align MAC address to u16 for is_valid_ether_addr()
Hi Thierry
The point of this patch was to try to avoid the pointer aliasing,
which is what leads to the alignment requirements. But if you are
forced to align it because of is_valid_ether_addr() i would just drop
this patch. Aliasing is going to happen whatever.
But if you want to keep it.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-02-06 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 12:30 [PATCH v3 1/2] r8169: Load MAC address from device tree if present Thierry Reding
2019-02-06 12:30 ` [PATCH v3 2/2] r8169: Avoid pointer aliasing Thierry Reding
2019-02-06 12:35 ` Thierry Reding
2019-02-06 13:28 ` Andrew Lunn [this message]
2019-02-06 21:40 ` David Miller
2019-02-06 12:33 ` [PATCH v3 1/2] r8169: Load MAC address from device tree if present Thierry Reding
2019-02-06 13:29 ` Andrew Lunn
2019-02-06 21:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206132816.GD20405@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pauldzim@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).