From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5FAC169C4 for ; Wed, 6 Feb 2019 13:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFD772186A for ; Wed, 6 Feb 2019 13:52:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="wslC7Gm+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729550AbfBFNwD (ORCPT ); Wed, 6 Feb 2019 08:52:03 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:41069 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727686AbfBFNwD (ORCPT ); Wed, 6 Feb 2019 08:52:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yJAK3U5bDBgj/MetyBJdfCPqXfhbKIhc9Kltnid0Ngg=; b=wslC7Gm+XJQia11t4gR6bHBjbv Avx+MwSF9KFv6LUqkz6QXKBXJgNnOhD3BozvRs6w1cm8BGrqwNcUZgGlLOz6OSgrAzANtfG53sYeK Rtz9Dz1NQ55WGIlPUNjiJhlVrKayBHT6Q244F/0EKrLra46chJQoQ8Cb51B4mVJb97C0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1grNcO-0006A0-Jl; Wed, 06 Feb 2019 14:52:00 +0100 Date: Wed, 6 Feb 2019 14:52:00 +0100 From: Andrew Lunn To: Pankaj Bansal Cc: Florian Fainelli , "netdev@vger.kernel.org" Subject: Re: [PATCH v4 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device Message-ID: <20190206135200.GA23409@lunn.ch> References: <20190206114523.8954-1-pankaj.bansal@nxp.com> <20190206114523.8954-2-pankaj.bansal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190206114523.8954-2-pankaj.bansal@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 06, 2019 at 06:20:39AM +0000, Pankaj Bansal wrote: > Add support for an MDIO bus multiplexer controlled by a regmap > device, like an FPGA. > > Tested on a NXP LX2160AQDS board which uses the "QIXIS" FPGA > attached to the i2c bus. > > Signed-off-by: Pankaj Bansal > --- > > Notes: > V4: > - No change > V3: > - No change > V2: > - New file describing the device tree bindings for regmap controlled devices' > mdio mux > > .../bindings/net/mdio-mux-regmap.txt | 167 +++++++++++++++++ > 1 file changed, 167 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/mdio-mux-regmap.txt b/Documentation/devicetree/bindings/net/mdio-mux-regmap.txt > new file mode 100644 > index 000000000000..8968f317965f > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mdio-mux-regmap.txt > @@ -0,0 +1,167 @@ > +Properties for an MDIO bus multiplexer controlled by a regmap > + > +This is a special case of a MDIO bus multiplexer. A regmap device, > +like an FPGA, is used to control which child bus is connected. The mdio-mux > +node must be a child of the device that is controlled by a regmap. > +The driver currently only supports devices with upto 32-bit registers. > + > +Required properties in addition to the generic multiplexer properties: > + > +- reg : integer, contains the offset of the register that controls the bus > + multiplexer. it can be 32 bit number. > + > +- mux-mask : integer, contains an 32 bit mask that specifies which > + bits in the register control the actual bus multiplexer. The > + 'reg' property of each child mdio-mux node must be constrained by > + this mask. Hi Pankaj Maybe you can address the comment about not having a compatible flag by commenting that this is a device tree fragment, which is expected to appear inside the binding of some other device. It is not a standalone device. Andrew