From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Jason Cooper <jason@lakedaemon.net>,
Kishon Vijay Abraham I <kishon@ti.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 5/6] net: marvell: neta: add comphy support
Date: Wed, 6 Feb 2019 16:09:28 +0100 [thread overview]
Message-ID: <20190206160928.56fb4808@bootlin.com> (raw)
In-Reply-To: <E1grLTv-00061v-Tw@rmk-PC.armlinux.org.uk>
Hello Russell,
On Wed, 06 Feb 2019 11:35:07 +0000
Russell King <rmk+kernel@armlinux.org.uk> wrote:
>+ if (pp->comphy) {
>+ enum phy_mode mode = PHY_MODE_INVALID;
>+
>+ switch (state->interface) {
>+ case PHY_INTERFACE_MODE_SGMII:
>+ case PHY_INTERFACE_MODE_1000BASEX:
>+ mode = PHY_MODE_SGMII;
PHY_MODE_SGMII no longer exists, the new PHY_MODE_ETHERNET must be used
with the correct submode now, so this doesn't build unfortunately.
>+ break;
>+ case PHY_INTERFACE_MODE_2500BASEX:
>+ mode = PHY_MODE_2500SGMII;
Same here.
Thanks,
Maxime
next prev parent reply other threads:[~2019-02-06 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 11:34 [PATCH net-next 0/6] Add comphy support for Armada 38x Russell King - ARM Linux admin
2019-02-06 11:34 ` [PATCH net-next 1/6] dt-bindings: phy: Armada 38x common phy bindings Russell King
2019-02-06 11:34 ` [PATCH net-next 2/6] phy: armada38x: add common phy support Russell King
2019-02-06 19:59 ` David Miller
2019-02-06 11:34 ` [PATCH net-next 3/6] ARM: dts: add description for Armada 38x common phy Russell King
2019-02-06 11:35 ` [PATCH net-next 4/6] dt-bindings: net: mvneta: add phys property Russell King
2019-02-06 11:35 ` [PATCH net-next 5/6] net: marvell: neta: add comphy support Russell King
2019-02-06 15:09 ` Maxime Chevallier [this message]
2019-02-06 17:23 ` Russell King - ARM Linux admin
2019-02-06 11:35 ` [PATCH net-next 6/6] ARM: dts: clearfog: add comphy settings for Ethernet interfaces Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206160928.56fb4808@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).