From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4650CC282CC for ; Wed, 6 Feb 2019 17:23:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 075A32081B for ; Wed, 6 Feb 2019 17:23:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="rTSSvM65" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730546AbfBFRXd (ORCPT ); Wed, 6 Feb 2019 12:23:33 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:57420 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727467AbfBFRXc (ORCPT ); Wed, 6 Feb 2019 12:23:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dmwNajKAWIRTsoARs9pKpiOfPGrhInLk2q8a7vJvj0w=; b=rTSSvM65BAN5Tue0X3p3ggQDq yQAnFTnmTnURWUbEyWwfJPLCee8R5ri+4WeSs9PlzwJqLSY1b8spQqPPRr14vy2f3IcAZJ2LGKE/9 VnfojhWgnIJJjG72rVfY7tbAdTaiuaRbmb05wsRxlD3Zq7K6D3D1iZ6nGSEbpu3ecKdPs=; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:36578) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1grQux-0003Fj-My; Wed, 06 Feb 2019 17:23:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1grQur-0005Ts-3a; Wed, 06 Feb 2019 17:23:17 +0000 Date: Wed, 6 Feb 2019 17:23:17 +0000 From: Russell King - ARM Linux admin To: Maxime Chevallier Cc: Andrew Lunn , Gregory Clement , Jason Cooper , Kishon Vijay Abraham I , Sebastian Hesselbarth , Thomas Petazzoni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH net-next 5/6] net: marvell: neta: add comphy support Message-ID: <20190206172316.olapzjsv7e3jr3nv@shell.armlinux.org.uk> References: <20190206113409.ko7lwuv5kb7l7rjo@shell.armlinux.org.uk> <20190206160928.56fb4808@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190206160928.56fb4808@bootlin.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 06, 2019 at 04:09:28PM +0100, Maxime Chevallier wrote: > Hello Russell, > > On Wed, 06 Feb 2019 11:35:07 +0000 > Russell King wrote: > > > >+ if (pp->comphy) { > >+ enum phy_mode mode = PHY_MODE_INVALID; > >+ > >+ switch (state->interface) { > >+ case PHY_INTERFACE_MODE_SGMII: > >+ case PHY_INTERFACE_MODE_1000BASEX: > >+ mode = PHY_MODE_SGMII; > > PHY_MODE_SGMII no longer exists, the new PHY_MODE_ETHERNET must be used > with the correct submode now, so this doesn't build unfortunately. > > >+ break; > >+ case PHY_INTERFACE_MODE_2500BASEX: > >+ mode = PHY_MODE_2500SGMII; > > Same here. Of course, I knew there was some reason I hadn't sent them yet... thanks for spotting. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up