From: Andrew Lunn <andrew@lunn.ch>
To: Moritz Fischer <mdf@kernel.org>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
hkallweit1@gmail.com, davem@davemloft.net
Subject: Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO
Date: Wed, 6 Feb 2019 22:59:05 +0100 [thread overview]
Message-ID: <20190206215905.GD32483@lunn.ch> (raw)
In-Reply-To: <20190206181040.29539-1-mdf@kernel.org>
On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote:
> Fix fixed_phy not checking GPIO if no link_update callback
> is registered.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
>
> Hi all,
>
> I've been trying to figure out where exactly this broke,
> it must've been somewhere when the file was refactored
> in connection with phylink?
Hi Moritz
With a quick inspection, i also cannot see where it broken.
I think part of the issue is that all the current users have moved
onto using phylink, and phylink polls the GPIO, rather than having
fixed_link do it.
I would prefer to understand exactly which change broke it. Without
knowing how it broke, it is hard to say if this is the correct fix.
What is your use-case? You Cc: the usb list. So a USB-Ethernet dongle?
But then why fixed-link?
Andrew
next prev parent reply other threads:[~2019-02-06 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 18:10 [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO Moritz Fischer
2019-02-06 21:59 ` Andrew Lunn [this message]
2019-02-06 22:28 ` Moritz Fischer
2019-02-07 3:00 ` Andrew Lunn
2019-02-07 3:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206215905.GD32483@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).