From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C148C169C4 for ; Wed, 6 Feb 2019 21:59:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3296A218B0 for ; Wed, 6 Feb 2019 21:59:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="PzMkdmDa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726567AbfBFV7J (ORCPT ); Wed, 6 Feb 2019 16:59:09 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:41631 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726484AbfBFV7I (ORCPT ); Wed, 6 Feb 2019 16:59:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MFiSZwv+Ype9qjUGpfLZ807RslWAh313AYjjHYkxCGg=; b=PzMkdmDaM0f94LbF8Rd62++B7B QoIRqTA8YBK9nAZwZwz1wgyd12qbm7mbx9f7S0zMVw19oFHhxBZbhwCl4qgQ02gX6DJEIr/SNXxDS TwqQYb/+jhbcyNZqAb25M0iEJQuWEx+LXvCcvscOorUtNh7xTUwsagcBHKdtEPnSoPwo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1grVDl-0001l7-RR; Wed, 06 Feb 2019 22:59:05 +0100 Date: Wed, 6 Feb 2019 22:59:05 +0100 From: Andrew Lunn To: Moritz Fischer Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net Subject: Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking GPIO Message-ID: <20190206215905.GD32483@lunn.ch> References: <20190206181040.29539-1-mdf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190206181040.29539-1-mdf@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote: > Fix fixed_phy not checking GPIO if no link_update callback > is registered. > > Signed-off-by: Moritz Fischer > --- > > Hi all, > > I've been trying to figure out where exactly this broke, > it must've been somewhere when the file was refactored > in connection with phylink? Hi Moritz With a quick inspection, i also cannot see where it broken. I think part of the issue is that all the current users have moved onto using phylink, and phylink polls the GPIO, rather than having fixed_link do it. I would prefer to understand exactly which change broke it. Without knowing how it broke, it is hard to say if this is the correct fix. What is your use-case? You Cc: the usb list. So a USB-Ethernet dongle? But then why fixed-link? Andrew