Netdev List
 help / color / mirror / Atom feed
From: Manish Chopra <manishc@marvell.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <aelior@marvell.com>,
	<mkalderon@marvell.com>, Rahul Verma <rverma@marvell.com>
Subject: [PATCH net 5/6] qed: Change verbosity for coalescing message.
Date: Wed, 6 Feb 2019 14:43:46 -0800	[thread overview]
Message-ID: <20190206224347.17054-6-manishc@marvell.com> (raw)
In-Reply-To: <20190206224347.17054-1-manishc@marvell.com>

From: Rahul Verma <rverma@marvell.com>

Fix unnecessary logging of message in an expected
default case where coalescing value read (via ethtool -c)
migh not be valid unless they are configured explicitly
in the hardware using ethtool -C.

Signed-off-by: Rahul Verma <rverma@marvell.com>
Signed-off-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
---
 drivers/net/ethernet/qlogic/qed/qed_l2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c b/drivers/net/ethernet/qlogic/qed/qed_l2.c
index 64ac95c..58be1c4 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
@@ -2871,7 +2871,8 @@ static int qed_get_coalesce(struct qed_dev *cdev, u16 *coal, void *handle)
 	p_hwfn = p_cid->p_owner;
 	rc = qed_get_queue_coalesce(p_hwfn, coal, handle);
 	if (rc)
-		DP_NOTICE(p_hwfn, "Unable to read queue coalescing\n");
+		DP_VERBOSE(cdev, QED_MSG_DEBUG,
+			   "Unable to read queue coalescing\n");
 
 	return rc;
 }
-- 
1.8.3.1


  parent reply	other threads:[~2019-02-06 22:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06 22:43 [PATCH net 0/6] qed*: Bug fixes Manish Chopra
2019-02-06 22:43 ` [PATCH net 1/6] qed: Fix EQ full firmware assert Manish Chopra
2019-02-06 22:43 ` [PATCH net 2/6] qed: Assign UFP TC value to vlan priority in UFP mode Manish Chopra
2019-02-06 22:43 ` [PATCH net 3/6] qed: Consider TX tcs while deriving the max num_queues for PF Manish Chopra
2019-02-06 22:43 ` [PATCH net 4/6] qede: Fix system crash on configuring channels Manish Chopra
2019-02-06 22:43 ` Manish Chopra [this message]
2019-02-06 22:43 ` [PATCH net 6/6] qed*: Advance drivers version to 8.37.0.20 Manish Chopra
2019-02-07  0:53 ` [PATCH net 0/6] qed*: Bug fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190206224347.17054-6-manishc@marvell.com \
    --to=manishc@marvell.com \
    --cc=aelior@marvell.com \
    --cc=davem@davemloft.net \
    --cc=mkalderon@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=rverma@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox