From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B122C282C2 for ; Thu, 7 Feb 2019 18:49:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C0D420821 for ; Thu, 7 Feb 2019 18:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbfBGSs7 (ORCPT ); Thu, 7 Feb 2019 13:48:59 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:50752 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726319AbfBGSs7 (ORCPT ); Thu, 7 Feb 2019 13:48:59 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A64A6146D5FA9; Thu, 7 Feb 2019 10:48:58 -0800 (PST) Date: Thu, 07 Feb 2019 10:48:58 -0800 (PST) Message-Id: <20190207.104858.2028156451560331960.davem@davemloft.net> To: liuhangbin@gmail.com Cc: netdev@vger.kernel.org, sbrivio@redhat.com, eric.dumazet@gmail.com Subject: Re: [PATCH v2 net 0/2] fix two kernel panics when disabled IPv6 on boot up From: David Miller In-Reply-To: <20190207103611.25046-1-liuhangbin@gmail.com> References: <20190206125111.5286-1-liuhangbin@gmail.com> <20190207103611.25046-1-liuhangbin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Feb 2019 10:48:58 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hangbin Liu Date: Thu, 7 Feb 2019 18:36:09 +0800 > When disabled IPv6 on boot up, since there is no ipv6 route tables, we should > not call rt6_lookup. Fix them by checking if we have inet6_dev pointer on > netdevice. > > v2: Fix idev reference leak, declarations and code mixing as Stefano, > Eric pointed. Since we only want to check if idev exists and not > reference it, use __in6_dev_get() insteand of in6_dev_get(). Series applied and queued up for -stable, thanks.