From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEEC1C282CC for ; Fri, 8 Feb 2019 02:17:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C923121916 for ; Fri, 8 Feb 2019 02:17:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727333AbfBHCRW (ORCPT ); Thu, 7 Feb 2019 21:17:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:55530 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbfBHCRV (ORCPT ); Thu, 7 Feb 2019 21:17:21 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 04EBE108B8735; Thu, 7 Feb 2019 18:17:20 -0800 (PST) Date: Thu, 07 Feb 2019 18:17:20 -0800 (PST) Message-Id: <20190207.181720.264383318203577068.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: phy: let genphy_c45_read_link manage the devices to check From: David Miller In-Reply-To: <7c00df20-b3e1-7ea9-2adb-004e6291d52c@gmail.com> References: <7c00df20-b3e1-7ea9-2adb-004e6291d52c@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 07 Feb 2019 18:17:21 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Thu, 7 Feb 2019 21:41:46 +0100 > Let genphy_c45_read_link manage the devices to check, this removes > overhead from callers. Add C22EXT to the list of excluded devices > because it doesn't implement the status register. According to the > 802.3 clause 45 spec registers 29.0 - 29.4 are reserved. > > At the moment we have very few clause 45 PHY drivers, so we are > lacking experience whether other drivers will have to exclude further > devices, or may need to check PHY XS. If we should figure out that > list of devices to check needs to be configurable, I think best will > be to add a device list member to struct phy_driver. > > v2: > - adjusted commit message > - exclude also device C22EXT from link checking > > Signed-off-by: Heiner Kallweit Applied.