* [PATCH] ath: move spin_lock_bh to spin_lock in tasklet
@ 2019-01-22 16:30 Zhiwei Jiang
2019-01-22 16:42 ` Kalle Valo
2019-02-07 15:01 ` Kalle Valo
0 siblings, 2 replies; 6+ messages in thread
From: Zhiwei Jiang @ 2019-01-22 16:30 UTC (permalink / raw)
To: qq282012236
Cc: ath9k-devel, kvalo, davem, linux-wireless, netdev, linux-kernel
as you are already in a tasklet, it is unnecessary to call
spin_lock_bh, because softirq already disable BH.
Signed-off-by: Zhiwei Jiang <qq282012236@gmail.com>
---
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 799010ed04e0..4e8e80ac8341 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -574,12 +574,12 @@ void ath9k_tx_failed_tasklet(unsigned long data)
{
struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
- spin_lock_bh(&priv->tx.tx_lock);
+ spin_lock(&priv->tx.tx_lock);
if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
- spin_unlock_bh(&priv->tx.tx_lock);
+ spin_unlock(&priv->tx.tx_lock);
return;
}
- spin_unlock_bh(&priv->tx.tx_lock);
+ spin_unlock(&priv->tx.tx_lock);
ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
}
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet
2019-01-22 16:30 [PATCH] ath: move spin_lock_bh to spin_lock in tasklet Zhiwei Jiang
@ 2019-01-22 16:42 ` Kalle Valo
[not found] ` <CANHzP_uiEoYaSg4fC1gHHjc=gRLjaxt8S3=p6a-rkg5-WjR7MA@mail.gmail.com>
2019-02-07 15:01 ` Kalle Valo
1 sibling, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2019-01-22 16:42 UTC (permalink / raw)
To: Zhiwei Jiang; +Cc: ath9k-devel, davem, linux-wireless, netdev, linux-kernel
Zhiwei Jiang <qq282012236@gmail.com> writes:
> as you are already in a tasklet, it is unnecessary to call
> spin_lock_bh, because softirq already disable BH.
>
> Signed-off-by: Zhiwei Jiang <qq282012236@gmail.com>
If you post a new version you should mark it as "v2":
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
No need to resend now but please keep in mind in the future.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet
2019-01-22 16:30 [PATCH] ath: move spin_lock_bh to spin_lock in tasklet Zhiwei Jiang
2019-01-22 16:42 ` Kalle Valo
@ 2019-02-07 15:01 ` Kalle Valo
1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-02-07 15:01 UTC (permalink / raw)
To: Zhiwei Jiang
Cc: qq282012236, ath9k-devel, davem, linux-wireless, netdev,
linux-kernel
Zhiwei Jiang <qq282012236@gmail.com> wrote:
> as you are already in a tasklet, it is unnecessary to call
> spin_lock_bh, because softirq already disable BH.
>
> Signed-off-by: Zhiwei Jiang <qq282012236@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
b789f333d7ac ath: move spin_lock_bh to spin_lock in tasklet
--
https://patchwork.kernel.org/patch/10775865/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ath: move spin_lock_bh to spin_lock in tasklet
@ 2019-01-19 10:55 Zhiwei Jiang
2019-01-22 12:59 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Zhiwei Jiang @ 2019-01-19 10:55 UTC (permalink / raw)
To: qq282012236
Cc: ath9k-devel, kvalo, davem, linux-wireless, netdev, linux-kernel
as you are already in a tasklet, it is unnecessary to call
spin_lock_bh, because softirq already disable BH.
Signed-off-by: Zhiwei Jiang <qq282012236@gmail.com>
---
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
index 799010ed04e0..4e38276ed0d3 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
@@ -574,12 +574,12 @@ void ath9k_tx_failed_tasklet(unsigned long data)
{
struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
- spin_lock_bh(&priv->tx.tx_lock);
+ spin_lock(&priv->tx.tx_lock);
if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
spin_unlock_bh(&priv->tx.tx_lock);
return;
}
- spin_unlock_bh(&priv->tx.tx_lock);
+ spin_unlock(&priv->tx.tx_lock);
ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
}
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet
2019-01-19 10:55 Zhiwei Jiang
@ 2019-01-22 12:59 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-01-22 12:59 UTC (permalink / raw)
To: kbuild, Zhiwei Jiang
Cc: kbuild-all, qq282012236, ath9k-devel, kvalo, davem,
linux-wireless, netdev, linux-kernel
Hi Zhiwei,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Zhiwei-Jiang/ath-move-spin_lock_bh-to-spin_lock-in-tasklet/20190121-185529
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
smatch warnings:
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c:584 ath9k_tx_failed_tasklet() warn: inconsistent returns 'bottom_half:'.
Locked on: line 584
Unlocked on: line 580
# https://github.com/0day-ci/linux/commit/953929a8fc22ae7ab9adafed62c84a11c4be2270
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 953929a8fc22ae7ab9adafed62c84a11c4be2270
vim +584 drivers/net/wireless/ath/ath9k/htc_drv_txrx.c
27876a29 Sujith Manoharan 2011-04-13 572
27876a29 Sujith Manoharan 2011-04-13 573 void ath9k_tx_failed_tasklet(unsigned long data)
27876a29 Sujith Manoharan 2011-04-13 574 {
27876a29 Sujith Manoharan 2011-04-13 575 struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
b587fc81 Sujith Manoharan 2011-04-13 576
953929a8 Zhiwei Jiang 2019-01-19 577 spin_lock(&priv->tx.tx_lock);
27876a29 Sujith Manoharan 2011-04-13 578 if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
27876a29 Sujith Manoharan 2011-04-13 579 spin_unlock_bh(&priv->tx.tx_lock);
^^^
Missed this one.
27876a29 Sujith Manoharan 2011-04-13 580 return;
b587fc81 Sujith Manoharan 2011-04-13 581 }
953929a8 Zhiwei Jiang 2019-01-19 582 spin_unlock(&priv->tx.tx_lock);
b587fc81 Sujith Manoharan 2011-04-13 583
27876a29 Sujith Manoharan 2011-04-13 @584 ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
b587fc81 Sujith Manoharan 2011-04-13 585 }
27876a29 Sujith Manoharan 2011-04-13 586
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-07 15:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-22 16:30 [PATCH] ath: move spin_lock_bh to spin_lock in tasklet Zhiwei Jiang
2019-01-22 16:42 ` Kalle Valo
[not found] ` <CANHzP_uiEoYaSg4fC1gHHjc=gRLjaxt8S3=p6a-rkg5-WjR7MA@mail.gmail.com>
2019-01-23 4:25 ` Kalle Valo
2019-02-07 15:01 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2019-01-19 10:55 Zhiwei Jiang
2019-01-22 12:59 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).