From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=t9U+=QO=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id ABB21C282C2
	for <netdev@archiver.kernel.org>; Thu,  7 Feb 2019 19:21:15 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 7ADB121917
	for <netdev@archiver.kernel.org>; Thu,  7 Feb 2019 19:21:15 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1549567275;
	bh=oHAcLJGGGXqXKgpfOf6KLJ9AmuZBmhy3sOQkPHXsRbo=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=EPW7yzBlTQ1V6raw8DtDP8BKRDUH59e2V4rb/kJhUOA+CG2LaObkrcsgiSJ09l+10
	 CXueD+7SiGlBop0VMnaUxt0rZk/AqAQR9xVTjF9IUCJdMWybnooMZbfDKlypBT9xSl
	 ckQRWlQQlxhkirJY+r85ALK4qdCLiD8bWh7paRQU=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726978AbfBGTVO (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 7 Feb 2019 14:21:14 -0500
Received: from mail.kernel.org ([198.145.29.99]:44848 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726319AbfBGTVO (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 7 Feb 2019 14:21:14 -0500
Received: from quaco.ghostprotocols.net (unknown [179.97.41.93])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 4463621917;
        Thu,  7 Feb 2019 19:21:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1549567273;
        bh=oHAcLJGGGXqXKgpfOf6KLJ9AmuZBmhy3sOQkPHXsRbo=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=v8q/Z06vpV0AWr3C2WnBTMUxJKDYqPmbLnECiwFTng7Hoo4KDLZVUHFZ8cjJfxrDS
         y3wlSl2/wDonUElVFIf5vRZAUMSDO5fFC0Zovy3yoTCUfm34zsJpY4jYrag4teyHKI
         qIP+fHlLBoqC6V7nhIvsZ7GV0U14hU6V9mqi8LNs=
Received: by quaco.ghostprotocols.net (Postfix, from userid 1000)
        id 8935E410BC; Thu,  7 Feb 2019 16:21:11 -0300 (-03)
Date:   Thu, 7 Feb 2019 16:21:11 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Andrii Nakryiko <andriin@fb.com>
Cc:     yhs@fb.com, songliubraving@fb.com, ast@fb.com, kafai@fb.com,
        netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH bpf-next] tools/bpf: add missing strings.h include
Message-ID: <20190207192111.GB6835@kernel.org>
References: <20190207175027.1950358-1-andriin@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190207175027.1950358-1-andriin@fb.com>
X-Url:  http://acmel.wordpress.com
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

Em Thu, Feb 07, 2019 at 09:50:27AM -0800, Andrii Nakryiko escreveu:
> Few files in libbpf are using bzero() function (defined in strings.h header), but
> don't include corresponding header. When libbpf is added as a dependency to pahole,
> this undeterministically causes warnings on some machines:
> 
> bpf.c:225:2: warning: implicit declaration of function ‘bzero’ [-Wimplicit-function-declaration]
>   bzero(&attr, sizeof(attr));
     ^~~~~

You forgot your:

Signed-off-by: Andrii Nakryiko <andriin@fb.com>

And a:

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>

:-)

- Arnaldo

> ---
>  tools/lib/bpf/bpf.c    | 1 +
>  tools/lib/bpf/btf.c    | 1 +
>  tools/lib/bpf/libbpf.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> index 3defad77dc7a..92fd27fe0599 100644
> --- a/tools/lib/bpf/bpf.c
> +++ b/tools/lib/bpf/bpf.c
> @@ -22,6 +22,7 @@
>   */
>  
>  #include <stdlib.h>
> +#include <strings.h>
>  #include <memory.h>
>  #include <unistd.h>
>  #include <asm/unistd.h>
> diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
> index ab6528c935a1..4324eb47d214 100644
> --- a/tools/lib/bpf/btf.c
> +++ b/tools/lib/bpf/btf.c
> @@ -4,6 +4,7 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
> +#include <strings.h>
>  #include <unistd.h>
>  #include <errno.h>
>  #include <linux/err.h>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 47969aa0faf8..8d64ada5f728 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -18,6 +18,7 @@
>  #include <libgen.h>
>  #include <inttypes.h>
>  #include <string.h>
> +#include <strings.h>
>  #include <unistd.h>
>  #include <fcntl.h>
>  #include <errno.h>
> -- 
> 2.17.1

-- 

- Arnaldo