From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E6DC282C2 for ; Thu, 7 Feb 2019 20:59:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC09C2175B for ; Thu, 7 Feb 2019 20:59:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="B0oHtnz2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbfBGU7x (ORCPT ); Thu, 7 Feb 2019 15:59:53 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:42994 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726832AbfBGU7x (ORCPT ); Thu, 7 Feb 2019 15:59:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OQYPTeeTSMni2o5BBw/AmW8XcC3vhg8r2vqCjH3XmQY=; b=B0oHtnz2qNuTz1Gp1xIHJki7EH ulJyExsoSOuVbXmAV5+ZI9wP/D5YEt+sQGJ2djXXcJtx2Pbvp4Jvwo4z0q3qxktdnVGP4mdAnbKJf XKi7N+pLDV6IXLVcXbDK1byXp4OYRcFSj2loW6D2rw8DPfo4TeN6gA+xFY8V6deM3zoU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1grqlw-0001Un-JZ; Thu, 07 Feb 2019 21:59:48 +0100 Date: Thu, 7 Feb 2019 21:59:48 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , Russell King , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 net-next] net: phy: let genphy_c45_read_link manage the devices to check Message-ID: <20190207205948.GD5223@lunn.ch> References: <7c00df20-b3e1-7ea9-2adb-004e6291d52c@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c00df20-b3e1-7ea9-2adb-004e6291d52c@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 07, 2019 at 09:41:46PM +0100, Heiner Kallweit wrote: > Let genphy_c45_read_link manage the devices to check, this removes > overhead from callers. Add C22EXT to the list of excluded devices > because it doesn't implement the status register. According to the > 802.3 clause 45 spec registers 29.0 - 29.4 are reserved. > > At the moment we have very few clause 45 PHY drivers, so we are > lacking experience whether other drivers will have to exclude further > devices, or may need to check PHY XS. If we should figure out that > list of devices to check needs to be configurable, I think best will > be to add a device list member to struct phy_driver. > > v2: > - adjusted commit message > - exclude also device C22EXT from link checking > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew