netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linux@armlinux.org.uk
Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
	hkallweit1@gmail.com
Subject: Re: [PATCH] net: sfp: do not probe SFP module before we're attached
Date: Fri, 08 Feb 2019 15:42:44 -0800 (PST)	[thread overview]
Message-ID: <20190208.154244.1158349966768699281.davem@davemloft.net> (raw)
In-Reply-To: <20190208233651.wdaywntcwwq63xpo@shell.armlinux.org.uk>

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Fri, 8 Feb 2019 23:36:51 +0000

> On Fri, Feb 08, 2019 at 03:11:39PM -0800, David Miller wrote:
>> From: Russell King <rmk+kernel@armlinux.org.uk>
>> Date: Wed, 06 Feb 2019 10:52:30 +0000
>> 
>> > When we probe a SFP module, we expect to be able to call the upstream
>> > device's module_insert() function so that the upstream link can be
>> > configured.  However, when the upstream device is delayed, we currently
>> > may end up probing the module before the upstream device is available,
>> > and lose the module_insert() call.
>> > 
>> > Avoid this by holding off probing the module until the SFP bus is
>> > properly connected to both the SFP socket driver and the upstream
>> > driver.
>> > 
>> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>> 
>> Applied, thanks Russell.
>> 
>> -stable?
> 
> Yes please.  Would you like me to mail the stable team once it hits
> mainline?

Networking -stable submissions are handled purely by me, so no you don't
need to do that.

I've queued this one up, thanks.

Thanks.

      reply	other threads:[~2019-02-08 23:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-06 10:52 [PATCH] net: sfp: do not probe SFP module before we're attached Russell King
2019-02-08 23:11 ` David Miller
2019-02-08 23:36   ` Russell King - ARM Linux admin
2019-02-08 23:42     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190208.154244.1158349966768699281.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).