From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=TiMe=QP=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A1F8FC169C4
	for <netdev@archiver.kernel.org>; Fri,  8 Feb 2019 23:42:47 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 6CABA218DA
	for <netdev@archiver.kernel.org>; Fri,  8 Feb 2019 23:42:47 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726655AbfBHXmq (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 8 Feb 2019 18:42:46 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:38358 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726020AbfBHXmq (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 8 Feb 2019 18:42:46 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 68B061017CA9F;
        Fri,  8 Feb 2019 15:42:45 -0800 (PST)
Date:   Fri, 08 Feb 2019 15:42:44 -0800 (PST)
Message-Id: <20190208.154244.1158349966768699281.davem@davemloft.net>
To:     linux@armlinux.org.uk
Cc:     netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com,
        hkallweit1@gmail.com
Subject: Re: [PATCH] net: sfp: do not probe SFP module before we're attached
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190208233651.wdaywntcwwq63xpo@shell.armlinux.org.uk>
References: <E1grKog-0004c1-OB@rmk-PC.armlinux.org.uk>
        <20190208.151139.1930176272346229162.davem@davemloft.net>
        <20190208233651.wdaywntcwwq63xpo@shell.armlinux.org.uk>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Feb 2019 15:42:45 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: Fri, 8 Feb 2019 23:36:51 +0000

> On Fri, Feb 08, 2019 at 03:11:39PM -0800, David Miller wrote:
>> From: Russell King <rmk+kernel@armlinux.org.uk>
>> Date: Wed, 06 Feb 2019 10:52:30 +0000
>> 
>> > When we probe a SFP module, we expect to be able to call the upstream
>> > device's module_insert() function so that the upstream link can be
>> > configured.  However, when the upstream device is delayed, we currently
>> > may end up probing the module before the upstream device is available,
>> > and lose the module_insert() call.
>> > 
>> > Avoid this by holding off probing the module until the SFP bus is
>> > properly connected to both the SFP socket driver and the upstream
>> > driver.
>> > 
>> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>> 
>> Applied, thanks Russell.
>> 
>> -stable?
> 
> Yes please.  Would you like me to mail the stable team once it hits
> mainline?

Networking -stable submissions are handled purely by me, so no you don't
need to do that.

I've queued this one up, thanks.

Thanks.