From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C7BC169C4 for ; Fri, 8 Feb 2019 07:02:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8C8921917 for ; Fri, 8 Feb 2019 07:02:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726290AbfBHHCE (ORCPT ); Fri, 8 Feb 2019 02:02:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:52290 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726004AbfBHHCE (ORCPT ); Fri, 8 Feb 2019 02:02:04 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5EE47AEB1; Fri, 8 Feb 2019 07:02:02 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id B37D1E0142; Fri, 8 Feb 2019 08:02:00 +0100 (CET) Date: Fri, 8 Feb 2019 08:02:00 +0100 From: Michal Kubecek To: netdev@vger.kernel.org Cc: "Nunley, Nicholas D" , "Kirsher, Jeffrey T" , "linville@tuxdriver.com" , "nhorman@redhat.com" , "sassmann@redhat.com" Subject: Re: [PATCH v2 3/6] ethtool: introduce new ioctl for per-queue settings Message-ID: <20190208070200.GA7035@unicorn.suse.cz> References: <20190206000106.24364-1-jeffrey.t.kirsher@intel.com> <20190206000106.24364-3-jeffrey.t.kirsher@intel.com> <20190206091832.GI21401@unicorn.suse.cz> <146CDE3B8C383A4B88452B498CB0FBBBFD9C3F87@ORSMSX157.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146CDE3B8C383A4B88452B498CB0FBBBFD9C3F87@ORSMSX157.amr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 07, 2019 at 11:37:19PM +0000, Nunley, Nicholas D wrote: > From: Michal Kubecek [mailto:mkubecek@suse.cz] > > On Tue, Feb 05, 2019 at 04:01:03PM -0800, Jeff Kirsher wrote: > > > Introduce a new ioctl for setting per-queue parameters. > > > Users can apply commands to specific queues by setting SUB_COMMAND > > and > > > queue_mask with the following ethtool command: > > > > > > ethtool --set-perqueue-command DEVNAME [queue_mask %x] > > SUB_COMMAND > > > > The "set" part is IMHO a bit confusing in combination with "show" type > > subcommands. > > I'm not a fan of the "set" either. This patch set had already gone > through some review before it was passed on to me, and the command > naming wasn't a previous point of contention and I didn't want to > disturb the parts that weren't "broken", but since you've brought it > up I agree that this may not be the best name. I think > "--perqueue-command" is more appropriate. Does this seem reasonable to > you? That sounds good, I would say either that or "--per-queue". Michal Kubecek