From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044FCC169C4 for ; Fri, 8 Feb 2019 07:59:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A54662077B for ; Fri, 8 Feb 2019 07:59:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Ol/+KjYs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbfBHH7I (ORCPT ); Fri, 8 Feb 2019 02:59:08 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40307 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbfBHH7I (ORCPT ); Fri, 8 Feb 2019 02:59:08 -0500 Received: by mail-ed1-f67.google.com with SMTP id g22so2002801edr.7 for ; Thu, 07 Feb 2019 23:59:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=uoEebkg3KrqxX/awfPzfhzQI2dCsdyk0htgeub4Ubk8=; b=Ol/+KjYsI5lU1BTgt5Ndkr8bY43HJZfzjbJ+92R5ON5WEyxI7Fq6sJrEMn4rB4/Uvv +GjtZoR5DT0VckizhC8rkvBCb2jmq4XIFaC1NoTY8XDWrppiZJUKE2UrQioTNhLMufU/ J/RMFRm4jSfJKgmHm2q3qS54pSR6yOpyk5hziC+aJ9+uucTgVu8aViADjqB6O8+CpBRM Hj1OJdepaE2vq+S7lMzqTG3T2midwQfLwymf8uH3K6mAkwkCV2fMMwHRSPljelZLX8hb xhIykqvAlEE2w3u/Y0TmFu7zzOHci9dIjrQLV4A2NFafpdDolG2fnQjVn/fkYQP1F0Ax E2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=uoEebkg3KrqxX/awfPzfhzQI2dCsdyk0htgeub4Ubk8=; b=GqNwT0uSOkdihokVWmRYbbbjel9bbyFJMe8DBhyjR9zVISjIROfRcqAxvSqPOxYeRA OmSlcLlyL4/xH/GtLTg/XfAK+yvMGftrTfI0mPuezy2Jus7aXXXLks1A9QPlClNO6YFT EFV+/e43pDmca03cdKwN6yvG0+ihj3m+M5RJopMLuRDUa+lvPKoY8YGG2VHCJ0uYvKZA WACKaNSweo9TO6SSe9A/Ft8+58IJsRJMb6emOIbtTvJjKmWcIQn/rW0N8n1gInW4f9cN S1MTLYhoos6WN6UzyL5ghtVDHPrtX+eZU7eGdKDu+t1zVOfoxUT8+bJNLr4XtpLpA//B 3H3w== X-Gm-Message-State: AHQUAuaPPGkr/XzDapfG2CQoT2UPm0XELp9sIX4afKp77DGFOkauGgJs ll+mcJIZDykZQPYFwnEnp5XEeg== X-Google-Smtp-Source: AHgI3IY/ii+QcA9pcDllO4rgDRK2MNbQfbmnjxLmqfmEl4rw8MKksL1Qym5uBVg63A/ggrhLqa/j2A== X-Received: by 2002:a50:de88:: with SMTP id c8mr15810164edl.129.1549612746506; Thu, 07 Feb 2019 23:59:06 -0800 (PST) Received: from netronome.com ([2001:982:756:703:d63d:7eff:fe99:ac9d]) by smtp.gmail.com with ESMTPSA id f5sm414085edt.64.2019.02.07.23.59.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Feb 2019 23:59:05 -0800 (PST) Date: Fri, 8 Feb 2019 08:59:04 +0100 From: Simon Horman To: David Miller Cc: gvrose8192@gmail.com, elibr@mellanox.com, pshelar@ovn.org, dev@openvswitch.org, netdev@vger.kernel.org Subject: Re: [ovs-dev] [PATCH net-next V2 1/1] openvswitch: Declare ovs key structures using macros Message-ID: <20190208075903.so63odmtuvxawija@netronome.com> References: <20190203091217.8459-1-elibr@mellanox.com> <0bbab6ba-5892-e0c3-8290-6d844414ca2e@gmail.com> <20190204.120900.211287782199950541.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190204.120900.211287782199950541.davem@davemloft.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 04, 2019 at 12:09:00PM -0800, David Miller wrote: > From: Gregory Rose > Date: Mon, 4 Feb 2019 11:41:29 -0800 > > > > > On 2/3/2019 1:12 AM, Eli Britstein wrote: > >> Declare ovs key structures using macros as a pre-step towards to > >> enable retrieving fields information, as a work done in proposed > >> commit in the OVS tree https://patchwork.ozlabs.org/patch/1023406/ > >> ("odp-util: Do not rewrite fields with the same values as matched"), > >> with no functional change. > >> > >> Signed-off-by: Eli Britstein > >> Reviewed-by: Roi Dayan > > > > Obscuring the structures with these macros is awful.  I'm opposed but > > I see it has already been > > accepted upstream so I guess that's that. > > I am personally in no way obligated to apply this patch to my tree > just because "upstream" did, and I absolutely have no plans to do so > at this point. > > This patch is absolutely awful. I hate to jump on a bandwagon, but this patch makes the code much less readable.