From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780CBC169C4 for ; Fri, 8 Feb 2019 16:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 479332086C for ; Fri, 8 Feb 2019 16:04:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="P8LoJpUE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727478AbfBHQEj (ORCPT ); Fri, 8 Feb 2019 11:04:39 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:44861 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbfBHQEi (ORCPT ); Fri, 8 Feb 2019 11:04:38 -0500 Received: by mail-qk1-f193.google.com with SMTP id r21so2359612qkl.11 for ; Fri, 08 Feb 2019 08:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=SILxUCWMAZzeKrgNQuUVE/eYMFJ3QpYWF4aw7NSCOIc=; b=P8LoJpUEwXQcqaIzdsBBEkaeNxWaX2YOHKuKWj8ZXak4jw7ufuQ0hEerMD9gcbIISy Y8frMfELCng4TZtT6Y/0yIaQQqLsTZOmp6U3FsfX1GJfcAlW7qIZm7yfor/uiqjxU4et A+q3gYbt9zocN8cDeagcul7g756XnZDq/oNr8WydSFwbiJJOntiYqhVA3tHzb6z50yuP df25QNSBlEv+6I26RaZyR1QrZn6aODTWoFnqsLKXPJiucnYzosV2h2oAYCyw7jYRZKAN 0GvEu6IVKz9QP+P6syc1nRjGcTU800+OopDmBsxc8f1TvtOm62Aw3yW7eL/aahufDNTu 6dyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=SILxUCWMAZzeKrgNQuUVE/eYMFJ3QpYWF4aw7NSCOIc=; b=OHBhWYWl2FXcl6k6ALGxfQ7EpBWVCP7imk2m4V4dpHjuj6q4qGBbQwPNn5f5auN2fv zLfLX9XVfOcNn+Q6VgX7brbZRF0ShMbbEaagqOkMH1oXmnqIgr73ahiUByEtYw7cPavd Vjcuy4kZyUPT4tKdjp1or7KhyTok2plRnOH4Qv4YIYLg1zRXQhQbM5fo4Q7F4i4EmwXF CcnxJo56TD8E8bPRnIU75WNK4mmEqIQhyUmen41ExpYcEzkN+3/j/dZd3AlH1eTdUUxo aT2kgLlGjPKgO85eBlqnDbQNpoVyWHiqHDFNei6J3yrpnAJEpYX5A+3TBCcFEAaXFAfw WEuA== X-Gm-Message-State: AHQUAuY0V1Yxi+27GXvH8UK0XQZ5JrU9r/IQgvJAiARkKzgM2wKQfaxo Ktj8SKi05VGfyel6SXI4HbI9cQ== X-Google-Smtp-Source: AHgI3Iavj+p4Kql26dIqi0vldcMt0KOvp2AMsQv7DX9fO5bbSNKSnjjTLxk5Jm/ZQy4S+M/+BGWw3A== X-Received: by 2002:a37:96c3:: with SMTP id y186mr11452641qkd.166.1549641877438; Fri, 08 Feb 2019 08:04:37 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d50sm5426295qta.31.2019.02.08.08.04.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 08:04:37 -0800 (PST) Date: Fri, 8 Feb 2019 08:04:29 -0800 From: Jakub Kicinski To: Sudarsana Reddy Kalluru Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , Ariel Elior , Michal Kalderon , Michal Kubecek Subject: Re: [EXT] Re: [PATCH net-next 0/2] qed*: SmartAN query support Message-ID: <20190208080429.0411ea05@cakuba.netronome.com> In-Reply-To: References: <20190207142012.4521-1-skalluru@marvell.com> <20190207115405.02563e74@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 8 Feb 2019 11:32:14 +0000, Sudarsana Reddy Kalluru wrote: > >On Thu, 7 Feb 2019 06:20:10 -0800, Sudarsana Reddy Kalluru wrote: > >> SmartAN feature detects the peer/cable capabilities and establishes > >> the link in the best possible configuration. > > > >It sounds familiar, I need to check with FW team, but I think we may be doing > >a similar thing, and adding a common API rather than ethtool flag would be > >preferable. > > > >Could you please share a little bit more detail? What are the configurations > >this would choose between? > > Jakub, > Following doc provides detailed information on this feature. We simply need a flag to display whether the feature is enabled in the hardware or not, hence adding it to "ethtool --show-priv-flags". > https://www.cavium.com/Dell/Documents/Converged/TB_Establishing_Adaptive_Links_with_SmartAN_Dell.pdf Thanks! Yes, that's exactly the same thing. In a nutshell trying different serdes and FEC speeds. I guess I'll just put adding an API for this down as a TODO, and add it once we have ethtool netlink. And keep IOCTL ethtool frozen until then. So I think the priv flag is fine for now.