From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC62C169C4 for ; Fri, 8 Feb 2019 16:47:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 046C32080F for ; Fri, 8 Feb 2019 16:47:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="IYplrSjl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbfBHQrj (ORCPT ); Fri, 8 Feb 2019 11:47:39 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:34829 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726747AbfBHQrj (ORCPT ); Fri, 8 Feb 2019 11:47:39 -0500 Received: by mail-qk1-f193.google.com with SMTP id w204so2494039qka.2 for ; Fri, 08 Feb 2019 08:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=QBL/tXTc15Dd5Rv0e2PndnGJ48MspK3HqsCBquKQ858=; b=IYplrSjlWxJ8tdI41JwIoLotdM7aZVqeZq5vMmrhWtYrtyBlEWyVsxn46OLjgzpDs4 PI452X14ncyUwfhWQiH6jyl6QhPgRup4JWEAioQwUxLCq1MM2Ui0NxVj3wHNuqB9dnTm RjgzCXk8+uuDaP1wO8xMeWGS3S1PT2msrjVpobCgDN8ILyIB6QWVF34OyOQNtn9SJ17m p18IQCnj/iny4S3jJzkmZCc+7rnm9vsl2o4rfkMZ3oQmOJhGx/1Fibaz17c5/CsmiTS8 sf6L9llLQCn+4KCX+HmvupYjIzUt5KPh0DMeLIpSU5SSIs8lcOouptQ/SYdTAV/uPIkx FU/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=QBL/tXTc15Dd5Rv0e2PndnGJ48MspK3HqsCBquKQ858=; b=djOqSXG5lr2VXU9v/Zonjyd3axAZ4eloYipk30N6qy2WPn3oo3mhlU22ndPuAHr3SA sw+KrgwJsjUExeWq9VKxWLq0VPKpfabYG4JI3RqsBsdk5SNwxMcdA7QYy5WLgBESFYqt Whv25efKtlS3oMSBJjVQQEK0WJZD9lKhTBKg7+IadnGA415J6cr51HoOMaoxHGd/8nEO lx06VW2j6MYx3hxnNwlU+tGJILIUdh88U82PQAVLaaotTjhvLlhsCnhj8kRf3gpezgyW ya3ubM53WhSONZFC5AxKiinmJD5QX+zGOuVg3Jylx+UktOa+RM/Bo9omEAAiMb31NT/l NVoQ== X-Gm-Message-State: AHQUAuaGIe6cDWyxyx/S+KflQwtTAi4w5dTKg9b/qCVQjLoh4nMJohNi DNVBIfBB8/qPZ1FBshLYstPUqSp4xN0= X-Google-Smtp-Source: AHgI3IaFQAlF32k/1RzpFoiZ01BEGSUyMLO/gSJePrppNzaTUMfMqnVTRGHIbK4VHPSOl4nknaEVAA== X-Received: by 2002:a37:af42:: with SMTP id y63mr16131027qke.251.1549644458550; Fri, 08 Feb 2019 08:47:38 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id s13sm7950qkl.71.2019.02.08.08.47.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 08:47:38 -0800 (PST) Date: Fri, 8 Feb 2019 08:47:31 -0800 From: Jakub Kicinski To: Pablo Neira Ayuso Cc: netdev@vger.kernel.org, davem@davemloft.net, oss-drivers@netronome.com Subject: Re: [PATCH net-next] nfp: flower: remove unused index from nfp_fl_pedit() Message-ID: <20190208084731.52434d84@cakuba.netronome.com> In-Reply-To: <20190208164113.8935-1-pablo@netfilter.org> References: <20190208164113.8935-1-pablo@netfilter.org> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 8 Feb 2019 17:41:13 +0100, Pablo Neira Ayuso wrote: > Static checker warning complains on uninitialized variable: > > drivers/net/ethernet/netronome/nfp/flower/action.c:618 nfp_fl_pedit() > error: uninitialized symbol 'idx'. > > Which is actually never used from the functions that take it as > parameter. Remove it. > > Fixes: 738678817573 ("drivers: net: use flow action infrastructure") Hardly a fix. It's completely unused. > Reported-by: Dan Carpenter > Signed-off-by: Pablo Neira Ayuso Ah, I was hoping you wouldn't notice :) Now the backport of this code got almost as excruciatingly painful as the match part :) But I guess nothing we can do about it: Acked-by: Jakub Kicinski