From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC0B9C169C4 for ; Fri, 8 Feb 2019 17:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBB802146E for ; Fri, 8 Feb 2019 17:56:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="n5gGpMl1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728170AbfBHR45 (ORCPT ); Fri, 8 Feb 2019 12:56:57 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:40354 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728143AbfBHR44 (ORCPT ); Fri, 8 Feb 2019 12:56:56 -0500 Received: by mail-pg1-f194.google.com with SMTP id z10so1891660pgp.7 for ; Fri, 08 Feb 2019 09:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wq1cV2vibXH6fyS3Ks3vCZywm1ybE6u/FP7tjkS+e/I=; b=n5gGpMl1nBoqUe+Dck4Kd+Z92VmDDx/Xiqxz+QBM43DuwFx150JsX5kwiPtVjUrh4f Mu5DSeAx+9h20Lxu6zo03UNAhPJy4dsMVmTFQ1Fdrwz7yH4+Zr4/7Auh644PpWDkwyfi bp7rfA7wSIcU3dmTMRAe/YaPV65WiqBdt3RFkG3BOQ3T6lQNZmaIe3BYHoTmMn3IwbJf JtZcvcAUBWN8/rAJ0cg6T2wzlLvgZPy6lY3XCtkTxyawUYR+m8YnpynoCYycoFTH8Bba ZRxObc3dJtMH5dXcp4gAhuxg3tkSQ53HDnVX7KAtjjkb83HRiXcg4vfEuDZRmcA5h84P cznw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wq1cV2vibXH6fyS3Ks3vCZywm1ybE6u/FP7tjkS+e/I=; b=T7HUatktfK8YxNsdwcDfOmUgyiPzjHvjI+67LQMGMhCkW2UB4WGm4uXyQk0DLh62Ma x0zGOUnn8VXmsG9Fqtdf+Iqs7me2YYmyWgZUfap6cjUX/VO/YV2Hvs5OibCvn3G74XQT 0TYMPqe8azt9shZpUw0B9OExsvIjtONY2g7kKD/vUevIZ/u5b5olkvdazvGFGB2wrQfl teU1t1g90TiqUCO2zBaVcUyTUnlJo+lPvBmLg/xq3WjIcPSxE/5XfgIXEfuDVeM8tdnS RwqOHt6MHFpbUp3+/URP21kPYJcopRSQa5dYpZnpZDFnPN9QESZMWkAihyqx2f+ic/JR wxHw== X-Gm-Message-State: AHQUAub9NN+CDxnbD2Ee0I8K8p01QXzi6+3Gf6qlaL+cqwaCSKMt5iVp nKJ9l91SFgkA+6aMm7giwQNvnw== X-Google-Smtp-Source: AHgI3IYPbHyzPUkDiaXYIOgE+wzHF5BnzRg/t+1vzrkHa0WpjNCAx7YiZInsncgQJxISAua41RnaWw== X-Received: by 2002:a63:920a:: with SMTP id o10mr21021600pgd.141.1549648614977; Fri, 08 Feb 2019 09:56:54 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r80sm3458590pfa.111.2019.02.08.09.56.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 09:56:54 -0800 (PST) Date: Fri, 8 Feb 2019 09:56:47 -0800 From: Stephen Hemminger To: Phil Sutter Cc: netdev@vger.kernel.org, Roopa Prabhu Subject: Re: [iproute PATCH] ip-link: Fix listing of alias interfaces Message-ID: <20190208095647.047abca3@hermes.lan> In-Reply-To: <20190207130527.9439-1-phil@nwl.cc> References: <20190207130527.9439-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 7 Feb 2019 14:05:27 +0100 Phil Sutter wrote: > Commit 50b9950dd9011 ("link dump filter") accidentally broke listing of > links in the old alias interface notation: > > | % ip link show eth0:1 > | RTNETLINK answers: No such device > | Cannot send link get request: No such device > > Prior to the above commit, link lookup was performed via ifindex > returned by if_nametoindex(). The latter uses SIOCGIFINDEX ioctl call > which on kernel side causes the colon-suffix to be dropped before doing > the interface lookup. Netlink API though doesn't care about that at all. > To keep things backward compatible, mimick ioctl API behaviour and drop > the colon-suffix prior to sending the RTM_GETLINK request. > > Fixes: 50b9950dd9011 ("link dump filter") > Signed-off-by: Phil Sutter It is a regression, but the original code was kind of broken. iproute2 doesn't need or want the old style alias interface notation.