From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2CFC169C4 for ; Fri, 8 Feb 2019 18:01:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44AA2218D9 for ; Fri, 8 Feb 2019 18:01:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="dJQ0+kVT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727726AbfBHSBd (ORCPT ); Fri, 8 Feb 2019 13:01:33 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:41908 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727343AbfBHSBd (ORCPT ); Fri, 8 Feb 2019 13:01:33 -0500 Received: by mail-pf1-f194.google.com with SMTP id b7so2015558pfi.8 for ; Fri, 08 Feb 2019 10:01:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Da60tB2ZBw/VfPznOk3wHuYhziiwrXRQm9HgCmKcsaY=; b=dJQ0+kVTZqOByU/PUHYaxZ9Kw7sIbE0R8LunGPDW5Qa2WIfPgl2dk8W+SOXvvY/nuj gKpZQ+HOKLxJzhEumWeUSiSZjOI/meWOw0/5Rm6vtZYjmeEQqmnpr9Hm+HKzZALO5fZs MBcMMUlq4uiEYSVhN6r31RH4WAcWwvBuzxpGCQA9RHrpS+NRERgJ5FEsF+a2qCAnUu3k sPtL6LoiEzXGDYY26HAlUpgsupXUoVPTgdEqzzx7jONwrxkJUu4M/HPA+fOqC4TtFhgQ Y317FuIrYaWgioTio6DLcOBiiJupf/uXEoH8hFFFeG2slL1n1DsxwG7QNpjCY2T6ReHz LbaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Da60tB2ZBw/VfPznOk3wHuYhziiwrXRQm9HgCmKcsaY=; b=MZEJguMNJVaIJTp80vPhIwoF3/LZCTPlJYdCJjDjbUJByOtKqbgC2cdWiwfNlXhA5p qt2RGpyKId2RydGi/o0qqt0rtTWN4OqENGpxbz3CSA0PdphRkLisitBjjYjppO1gTqSv 5z/bDI+w2s2tHlaObB+AOEwSpGK3UCgsrQVqUGfqfEjD9khNnG7qKoHVmSNEZgNxkTpN /h5jPNdL4wRSEX/a6f9nlknGWNtbpxGmL+7A0E+aNqedqQ7yl+NKcpPPbSBfjZGaK+Jz lUJp3euVXOWNpqpui55DE9EvBVTlDSQGVduzvFU3fp8F4ggKlGlkQyrtWl/mzdxSwsZZ 7efA== X-Gm-Message-State: AHQUAuZCM+r+901+YQQ7xnR6UjoSGxpzyeG9f0bqYnyYBJa4WcCVoHOU Gu02PoIOtA2Yl7odldbB6DGBfPXL71o= X-Google-Smtp-Source: AHgI3Ib8LmKdqjbdxbW7aMs8SsNmcuqklsgr8Qm9F9H8W7kC7TW+9VbIjTYPlqAanL0Ac7iYsIsRQg== X-Received: by 2002:a65:63d3:: with SMTP id n19mr21840998pgv.179.1549648892259; Fri, 08 Feb 2019 10:01:32 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d129sm6542115pfc.31.2019.02.08.10.01.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Feb 2019 10:01:32 -0800 (PST) Date: Fri, 8 Feb 2019 10:01:24 -0800 From: Stephen Hemminger To: Marcos Antonio Moraes Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2] tc: use bits not mbits/sec in rate percent Message-ID: <20190208100124.56377c01@hermes.lan> In-Reply-To: <20190207152954.11036-1-marcos.antonio@digirati.com.br> References: <20190207152954.11036-1-marcos.antonio@digirati.com.br> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 7 Feb 2019 13:29:54 -0200 Marcos Antonio Moraes wrote: > As /sys/class/net//speed indicates a value in Mbits/sec, the > conversion is necessary to create the correct limits. > > This guarantees the same result for the following commands in an > 1000Mbit/sec device: > > tc class add ... htb rate 500Mbit > tc class add ... htb rate 50% > > Fixes: 927e3cfb52b5 ("tc: B.W limits can now be specified in %.") > Signed-off-by: Marcos Antonio Moraes Sure applied.