From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EB3AC169C4 for ; Fri, 8 Feb 2019 13:29:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67B7F20844 for ; Fri, 8 Feb 2019 13:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727513AbfBHN3r (ORCPT ); Fri, 8 Feb 2019 08:29:47 -0500 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:51572 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726624AbfBHN3r (ORCPT ); Fri, 8 Feb 2019 08:29:47 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1gs6Dt-0002ET-Sw; Fri, 08 Feb 2019 14:29:42 +0100 Date: Fri, 8 Feb 2019 14:29:41 +0100 From: Florian Westphal To: Daniel Borkmann Cc: davem@davemloft.net, netdev@vger.kernel.org, Mahesh Bandewar , Florian Westphal , Martynas Pumputis Subject: Re: [PATCH net-next] ipvlan: decouple l3s mode dependencies from other modes Message-ID: <20190208132941.bmbvuqckocuyhujr@breakpoint.cc> References: <20190208125531.28970-1-daniel@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190208125531.28970-1-daniel@iogearbox.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Daniel Borkmann wrote: > Right now ipvlan has a hard dependency on CONFIG_NETFILTER and > otherwise it cannot be built. However, the only ipvlan operation > mode that actually depends on netfilter is l3s, everything else > is independent of it. Break this hard dependency such that users > are able to use ipvlan l3 mode on systems where netfilter is not > compiled in. > > Therefore, this adds a hidden CONFIG_IPVLAN_L3S bool which is > defaulting to y when CONFIG_NETFILTER is set in order to retain > existing behavior for l3s. All l3s related code is refactored > into ipvlan_l3s.c that is compiled in when enabled. IIRC L3S is only meaningful with netfilter anyway, so this looks like a good thing to do. Acked-by: Florian Westphal