From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FBD2C169C4 for ; Fri, 8 Feb 2019 17:05:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9BC720863 for ; Fri, 8 Feb 2019 17:05:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="EkAzaoUq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727833AbfBHRFM (ORCPT ); Fri, 8 Feb 2019 12:05:12 -0500 Received: from mail-eopbgr00068.outbound.protection.outlook.com ([40.107.0.68]:19766 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727139AbfBHRFM (ORCPT ); Fri, 8 Feb 2019 12:05:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=14HCP3d2Q21Cmf07FKeHh/OPcgF4Ucwbe+uQ0qwcN/4=; b=EkAzaoUqPD4BhWGve180In2XmZS62BWriYsKQvINHQNYuFelWwle1v6/H7R62oMw7kAHLfiB6URRfdQlyzSP4jRjTMnEgM1CX6waw3KJ42VcmENl5p6REbJ7zENi8KkoUVa6qGQWXuLEgjMiVKsLtE3k5QnylJkLgmhjT1proO0= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB5685.eurprd05.prod.outlook.com (20.178.92.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.17; Fri, 8 Feb 2019 17:05:08 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1601.016; Fri, 8 Feb 2019 17:05:08 +0000 From: Ido Schimmel To: David Ahern CC: "netdev@vger.kernel.org" , "davem@davemloft.net" , Jiri Pirko , Alexander Petrovskiy , mlxsw Subject: Re: [PATCH net-next 1/2] mlxsw: spectrum_router: Offload blackhole routes Thread-Topic: [PATCH net-next 1/2] mlxsw: spectrum_router: Offload blackhole routes Thread-Index: AQHUvlQHCZauNWxOVk+h4tbYThYSFKXVEQmAgABzqACAAJRGgIAACzuA Date: Fri, 8 Feb 2019 17:05:07 +0000 Message-ID: <20190208170501.GA18798@splinter> References: <20190206194140.18606-1-idosch@mellanox.com> <20190206194140.18606-2-idosch@mellanox.com> <18da8b4d-5966-e851-46d6-e389e40b865e@gmail.com> <20190208073408.GA26396@splinter> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P193CA0116.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::21) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [79.178.32.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM6PR05MB5685;6:eDJsK1wwIIgnwFYHMpQt2dRzjcrdhGlYSNKq1os7lQYkVBnbux03S8kbhI4VTJ67D4CxqxJ7Uk01t/b8Tm0LbBHkZ2uL/qh3gNHsFRSOzr3c03rkMFSRpFPEWEiloYUnvSnoUR2fpC6PdAYWuEf82R6hrRGWYlMy1CZ2OhYtM6Fy1enX4xXBbwEeglD87RyDG7ajxitkrDGHbzcrG5iwujrgqOmMoy/4wXOAvTnFDohUnka4cBF2y43D+V6QyxlVzZCIn2ChafHu1rCqz6FL1aM7Q73J+FXvLtofErvynAGel6z8/e6Sgo2BtKe7m5ycUUU/3kMs4TxSlUuOHGSqNDWfD3CAkhihivC161fLh1R/VxrGn40nv+Qfnrmo6+h3LGp0kJob7rkQLHCMNfU6mg2mUbq8Sx8Jt75J+k/o6fNSFpFZA77Nj5/4grVU5H2ZOl0nlVfhmIQ5Ken/GMuIgg==;5:UsfPTll+w8onkMq689a3vQDAIsD8pI8tGJZBWZw+ndmKtD6HutQ7WISATvf88Rxrer4US+Un03qnxPzR1lE/F5tW6ybKSS4kV0QNruwkAa60ALtmDA7vgr/ACqk/J9w3dV0Sr82Y3VeCbk6e3iSUmE1uSskj7TrbfM1G6gzMjIAEDNUsZZNZR/msbeqeOQT6l6/yGtYGO5hTass7hZPzmg==;7:sBiZc3OdMIJPQopZmyh8jpFsPmC9KxiYbqMR73qQysVzELrzl/NKsI7g+lOkhy0awm1p3LK953ByJHbFeexRwWs1hGOZygFIzx+58UE0r1tCqG1UP/7odw+P2zZ+eps2l84q2OTDanGTLPeq+2jgGg== x-ms-office365-filtering-correlation-id: 71d72717-7afa-465e-988c-08d68de793ad x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM6PR05MB5685; x-ms-traffictypediagnostic: AM6PR05MB5685: x-microsoft-antispam-prvs: x-forefront-prvs: 094213BFEA x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(39860400002)(396003)(366004)(136003)(376002)(346002)(199004)(189003)(4326008)(105586002)(53546011)(386003)(102836004)(33896004)(81166006)(7736002)(93886005)(99286004)(6506007)(25786009)(107886003)(6916009)(76176011)(53936002)(6512007)(305945005)(9686003)(8936002)(26005)(106356001)(1411001)(6486002)(8676002)(81156014)(54906003)(316002)(186003)(71190400001)(71200400001)(33656002)(68736007)(4744005)(14454004)(476003)(256004)(66066001)(478600001)(86362001)(11346002)(52116002)(229853002)(6436002)(6246003)(3846002)(446003)(97736004)(1076003)(2906002)(33716001)(486006)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB5685;H:AM6PR05MB5240.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IX4w9epD9raYBNmRvF+XKf8vHG1vl1LLbnt+4UMYY6nDMsL28FgZYbMcVYsXt6nM9OeU67k/u4FDnt/SMto2JUyLg+HJ/iqJVzQ/+xA2GlYhMVN1HsQSd2U/97nx00PJ/B7RLJKd8e4I7MxmJPKSV8lp3bolw5xuet2GSqjKR8a59kr7mCv2j6sQ1y6JpuaY9kb2RwLEU8xSpkzK0Vw5HHNB6e9KbFGnldEWWcGnahu3j6hlV28SXlYg5tfM9KLnc2VnEvG0g9MPmEbbvRbPd+sYRIRJtYgKI7DPeZV6g4PJrEOKTiNh2/3canZrlKxBx0VeaX9SX7PFdltcZch6EidF94JqWs+yMfGRHq4lSEVgGHCr7gUh0Oe7Lyr2Fqgx7ECUeYBMnBZ7rlJ3Q2gWsL1AbjuOi7hgEyUUAujM+iQ= Content-Type: text/plain; charset="us-ascii" Content-ID: <0732BDE13CFAAD44B9A74D07878830C1@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71d72717-7afa-465e-988c-08d68de793ad X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2019 17:05:07.1601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5685 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 08, 2019 at 08:24:49AM -0800, David Ahern wrote: > On 2/7/19 11:34 PM, Ido Schimmel wrote: > > I assume that user can't put blackhole and normal nexthops in the same > > group? > >=20 >=20 > I allow a nexthop group to reference a nexthop that is a blackhole, but > the group can only contain the one entry. That allows multipath routes > to toggle between a blackhole and a real spec. Good, thanks. I was afraid users will be able to configure a nexthop group that will randomly drop flows :)