From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77DD3C169C4 for ; Fri, 8 Feb 2019 20:19:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46D71218D2 for ; Fri, 8 Feb 2019 20:19:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="WzE01DIH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbfBHUT5 (ORCPT ); Fri, 8 Feb 2019 15:19:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:44588 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726222AbfBHUT5 (ORCPT ); Fri, 8 Feb 2019 15:19:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EqeLxEkJCWPUWp06ZaX6kSrtPzPMgWmYdf3UspvX/hI=; b=WzE01DIHKB/qBQEZf7FKrDRw+I bQZn1XcG7sHx8NQiUmsKTwEBMsY7kHELbvZr9CTTFASz+cd5RCsuw1f22ua983BBBCDaS7ZrxTyQM Na2XdRUKmOGLp+SWibmDC4N1e4FnBHAig/QubkvLz7A80QS+GmizG6hfG0IASWnYCWGQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gsCcs-0002TV-9t; Fri, 08 Feb 2019 21:19:54 +0100 Date: Fri, 8 Feb 2019 21:19:54 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH v3 1/3 net-next] net: phy: remove unneeded masking of PHY register read results Message-ID: <20190208201954.GI1853@lunn.ch> References: <75c9d8ee-582f-f247-7595-d8732ac26c20@gmail.com> <3585a862-6a2c-87f8-63e8-bfb46708707e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3585a862-6a2c-87f8-63e8-bfb46708707e@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 08, 2019 at 08:20:34PM +0100, Heiner Kallweit wrote: > PHY registers are only 16 bits wide, therefore, if the read was > successful, there's no need to mask out the higher 16 bits. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew