From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD1A9C169C4 for ; Fri, 8 Feb 2019 23:36:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B0B6218DA for ; Fri, 8 Feb 2019 23:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="P6yeSKT7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfBHXg5 (ORCPT ); Fri, 8 Feb 2019 18:36:57 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:38578 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbfBHXg5 (ORCPT ); Fri, 8 Feb 2019 18:36:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5UVADwixVx8y/EV6Fc0RZS7rEfkyIOAeMImu0idc4bc=; b=P6yeSKT7uXm//MTV2qHnCp2HG nJ/Cn2QU4Df30uO5A3SOfvry3pChE1d8ZNtWUoxGLx1ZKxm704xmHB4VJwY5mLqAJ7KnUDqoWgFIT beC550U/xs+ceVQJx6o4fBxFbYu90WqJNSyKdm5W+OsZOq/hVaD22Fj/23z1PZ8wrhDeo=; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:36674) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gsFhV-0004Ba-Ha; Fri, 08 Feb 2019 23:36:53 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1gsFhT-0007S4-F9; Fri, 08 Feb 2019 23:36:51 +0000 Date: Fri, 8 Feb 2019 23:36:51 +0000 From: Russell King - ARM Linux admin To: David Miller Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com Subject: Re: [PATCH] net: sfp: do not probe SFP module before we're attached Message-ID: <20190208233651.wdaywntcwwq63xpo@shell.armlinux.org.uk> References: <20190208.151139.1930176272346229162.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190208.151139.1930176272346229162.davem@davemloft.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 08, 2019 at 03:11:39PM -0800, David Miller wrote: > From: Russell King > Date: Wed, 06 Feb 2019 10:52:30 +0000 > > > When we probe a SFP module, we expect to be able to call the upstream > > device's module_insert() function so that the upstream link can be > > configured. However, when the upstream device is delayed, we currently > > may end up probing the module before the upstream device is available, > > and lose the module_insert() call. > > > > Avoid this by holding off probing the module until the SFP bus is > > properly connected to both the SFP socket driver and the upstream > > driver. > > > > Signed-off-by: Russell King > > Applied, thanks Russell. > > -stable? Yes please. Would you like me to mail the stable team once it hits mainline? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up